From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: Bugfix: offsetof in klibc
Date: Thu, 12 Feb 2004 23:20:55 +0000 [thread overview]
Message-ID: <20040212232055.GB21117@vrfy.org> (raw)
In-Reply-To: <401F9033.3080907@suse.de>
On Thu, Feb 12, 2004 at 02:52:07PM -0800, Greg KH wrote:
> On Tue, Feb 03, 2004 at 01:12:35PM +0100, Hannes Reinecke wrote:
> > Hi all, hpa,
> >
> > there is a small typo in stddef.h:offsetof()
> >
> > === stddef.h 1.1 vs edited ==> > --- 1.1/klibc/klibc/include/stddef.h Wed Oct 22 19:37:29 2003
> > +++ edited/stddef.h Tue Feb 3 10:16:15 2004
> > @@ -19,6 +19,6 @@
> > #endif
> >
> > #undef offsetof
> > -#define offsetof(t,m) ((size_t)&((t *)0->m))
> > +#define offsetof(t,m) ((size_t)&((t *)0)->m)
> >
> > #endif /* _STDDEF_H */
> >
> > otherwise the compiler complains and I suspect it will generated invalid
> > code anyway.
>
> Don't you mean to send this to the klibc mailing list?
We are using offsetof() now, with the private data db patch :)
So we have to fix it too, until klibc is fixed.
Kay
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-02-12 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-03 12:12 Bugfix: offsetof in klibc Hannes Reinecke
2004-02-12 22:52 ` Greg KH
2004-02-12 23:20 ` Kay Sievers [this message]
2004-02-12 23:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040212232055.GB21117@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).