From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] Adding '%s' format specifier to NAME and SYMLINK
Date: Mon, 16 Feb 2004 21:40:35 +0000 [thread overview]
Message-ID: <20040216214034.GA22823@kroah.com> (raw)
In-Reply-To: <402892DC.4000003@suse.de>
On Sat, Feb 14, 2004 at 07:32:58PM +0100, Kay Sievers wrote:
> On Thu, Feb 12, 2004 at 05:34:57PM -0800, Greg KH wrote:
> > On Tue, Feb 10, 2004 at 09:14:20AM +0100, Hannes Reinecke wrote:
> > > Hi all,
> > >
> > > this patch makes the format for NAME and SYMLINK a bit more flexible:
> > > I've added a new format specifier '%s{<SYSFS_var>}', which allows for
> > > the value of any sysfs entry found for this device to be inserted.
> > > Example (for our S/390 fcp adapter):
> > >
> > > BUS="ccw", SYSFS_devtype="1732/03", NAME="%k" \
> > > SYMLINK="zfcp-%s{hba_id}-%s{wwpn}:%s{fcp_lun}"
> > >
> > > I know this could also be done with an external program, but having this
> > > incorporated into udev makes life easier, especially if run from
> > > initramfs. Plus it makes the rules easier to follow, as the result is
> > > directly visible and need not to be looked up in some external program.
> > >
> > > Comments etc. welcome.
> >
> > Oops, sorry I missed this for the 017 release. I'll look at it tomorrow
> > and get back to you. At first glance it looks like a good thing.
> >
> > Oh, you forgot to update the documentation, that's important to do if
> > you want this change to make it in :)
>
> I took a part of the code and made a version that uses already implemented
> attribute finding logic.
>
> The parsing of the format length '%3x' and the '%x{attribute}' is a fuction now,
> maybe there are more possible users in the future.
>
> I've also added the test to udev-test.pl.
Nice cleanup. I've applied this.
thanks,
greg k-h
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-02-16 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-10 8:14 [PATCH] Adding '%s' format specifier to NAME and SYMLINK Hannes Reinecke
2004-02-13 1:34 ` Greg KH
2004-02-14 18:32 ` Kay Sievers
2004-02-15 2:36 ` Kay Sievers
2004-02-16 0:54 ` Kay Sievers
2004-02-16 21:40 ` Greg KH [this message]
2004-02-16 21:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040216214034.GA22823@kroah.com \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).