From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 16 Feb 2004 21:40:35 +0000 Subject: Re: [PATCH] Adding '%s' format specifier to NAME and SYMLINK Message-Id: <20040216214034.GA22823@kroah.com> List-Id: References: <402892DC.4000003@suse.de> In-Reply-To: <402892DC.4000003@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Sat, Feb 14, 2004 at 07:32:58PM +0100, Kay Sievers wrote: > On Thu, Feb 12, 2004 at 05:34:57PM -0800, Greg KH wrote: > > On Tue, Feb 10, 2004 at 09:14:20AM +0100, Hannes Reinecke wrote: > > > Hi all, > > > > > > this patch makes the format for NAME and SYMLINK a bit more flexible: > > > I've added a new format specifier '%s{}', which allows for > > > the value of any sysfs entry found for this device to be inserted. > > > Example (for our S/390 fcp adapter): > > > > > > BUS="ccw", SYSFS_devtype="1732/03", NAME="%k" \ > > > SYMLINK="zfcp-%s{hba_id}-%s{wwpn}:%s{fcp_lun}" > > > > > > I know this could also be done with an external program, but having this > > > incorporated into udev makes life easier, especially if run from > > > initramfs. Plus it makes the rules easier to follow, as the result is > > > directly visible and need not to be looked up in some external program. > > > > > > Comments etc. welcome. > > > > Oops, sorry I missed this for the 017 release. I'll look at it tomorrow > > and get back to you. At first glance it looks like a good thing. > > > > Oh, you forgot to update the documentation, that's important to do if > > you want this change to make it in :) > > I took a part of the code and made a version that uses already implemented > attribute finding logic. > > The parsing of the format length '%3x' and the '%x{attribute}' is a fuction now, > maybe there are more possible users in the future. > > I've also added the test to udev-test.pl. Nice cleanup. I've applied this. thanks, greg k-h ------------------------------------------------------- SF.Net is sponsored by: Speed Start Your Linux Apps Now. Build and deploy apps & Web services for Linux with a free DVD software kit from IBM. Click Now! http://ads.osdn.com/?ad_id56&alloc_id438&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel