From: Olaf Hering <olh@suse.de>
To: linux-hotplug@vger.kernel.org
Subject: Re: udev causing stale device nodes
Date: Mon, 23 Feb 2004 21:05:07 +0000 [thread overview]
Message-ID: <20040223210507.GA25332@suse.de> (raw)
In-Reply-To: <200402231420.17309.arnd@arndb.de>
On Mon, Feb 23, Arnd Bergmann wrote:
> a) Always remove all udev-created nodes before udev starts
Do you know a good reason to not rm the node and symlink before
creating them? I do it that way.
--- udev-add.c.orig 2004-02-17 18:40:39.000000000 +0000
+++ udev-add.c 2004-02-17 18:53:47.000000000 +0000
@@ -103,6 +103,7 @@ static int make_node(char *filename, int
{
int retval;
+ unlink(filename);
retval = mknod(filename, mode, makedev(major, minor));
if (retval != 0) {
dbg("mknod(%s, %#o, %u, %u) failed with error '%s'",
@@ -133,7 +134,6 @@ static int make_node(char *filename, int
static int create_node(struct udevice *dev, int fake)
{
- struct stat stats;
char filename[255];
char linktarget[255];
char partitionname[255];
@@ -247,18 +247,13 @@ static int create_node(struct udevice *d
i++;
}
- if (linktarget[0] = '\0')
- strcpy(linktarget, "./");
strcat(linktarget, &dev->name[tail]);
/* unlink existing files to ensure that our symlink is created */
- if (!fake && (lstat(filename, &stats) = 0)) {
- if ((stats.st_mode & S_IFMT) != S_IFDIR) {
+ if (!fake)
if (unlink(filename))
dbg("unlink(%s) failed with error '%s'",
filename, strerror(errno));
- }
- }
dbg("symlink(%s, %s)", linktarget, filename);
if (!fake) {
--
USB is for mice, FireWire is for men!
sUse lINUX ag, n√úRNBERG
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-02-23 21:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-23 13:20 udev causing stale device nodes Arnd Bergmann
2004-02-23 21:05 ` Olaf Hering [this message]
2004-02-23 22:35 ` Greg KH
2004-02-23 23:12 ` Kay Sievers
2004-02-23 23:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040223210507.GA25332@suse.de \
--to=olh@suse.de \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).