From: Michael Buesch <mbuesch@freenet.de>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] udev buffer overrun fix (2nd try)
Date: Tue, 24 Feb 2004 20:14:37 +0000 [thread overview]
Message-ID: <200402242114.37879.mbuesch@freenet.de> (raw)
Hi,
This patch fixes possible buffer overruns in create_node().
--- udev-add.c.orig 2004-02-24 15:24:13.000000000 +0100
+++ udev-add.c 2004-02-24 21:10:33.000000000 +0100
@@ -146,7 +146,7 @@
int tail;
strncpy(filename, udev_root, sizeof(filename));
- strncat(filename, dev->name, sizeof(filename));
+ strncat(filename, dev->name, sizeof(filename) - strlen(udev_root) - 1);
switch (dev->type) {
case 'b':
@@ -226,7 +226,7 @@
break;
strncpy(filename, udev_root, sizeof(filename));
- strncat(filename, linkname, sizeof(filename));
+ strncat(filename, linkname, sizeof(filename) - strlen(udev_root) - 1);
dbg("symlink '%s' to node '%s' requested", filename, dev->name);
if (!fake)
if (strrchr(linkname, '/'))
@@ -243,13 +243,15 @@
}
while (linkname[i] != '\0') {
if (linkname[i] = '/')
- strcat(linktarget, "../");
+ strncat(linktarget, "../",
+ sizeof(linktarget) - strlen(linktarget) - 1);
i++;
}
if (linktarget[0] = '\0')
strcpy(linktarget, "./");
- strcat(linktarget, &dev->name[tail]);
+ strncat(linktarget, &dev->name[tail],
+ sizeof(linktarget) - strlen(linktarget) - 1);
/* unlink existing files to ensure that our symlink is created */
if (!fake && (lstat(filename, &stats) = 0)) {
--
Regards Michael Buesch [ http://www.tuxsoft.de.vu ]
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
reply other threads:[~2004-02-24 20:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402242114.37879.mbuesch@freenet.de \
--to=mbuesch@freenet.de \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).