From: Michael Buesch <mbuesch@freenet.de>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] udev fix another buffer overrun
Date: Tue, 24 Feb 2004 20:26:01 +0000 [thread overview]
Message-ID: <200402242125.52122.mbuesch@freenet.de> (raw)
Hi,
This patch fixes just another possible buffer overrun
caused by the dangerous sprintf().
--- udev-add.c.orig 2004-02-24 21:17:51.000000000 +0100
+++ udev-add.c 2004-02-24 21:22:34.000000000 +0100
@@ -210,9 +210,14 @@
info("creating device partition nodes '%s[1-%i]'", filename, dev->partitions);
if (!fake) {
for (i = 1; i <= dev->partitions; i++) {
- sprintf(partitionname, "%s%i", filename, i);
- make_node(partitionname, dev->major,
- dev->minor + i, dev->mode, uid, gid);
+ retval = snprintf(partitionname, sizeof(partitionname),
+ "%s%i", filename, i);
+ if (retval >= sizeof(partitionname)) {
+ dbg("partitionname buffer too small");
+ } else {
+ make_node(partitionname, dev->major,
+ dev->minor + i, dev->mode, uid, gid);
+ }
}
}
}
--
Regards Michael Buesch [ http://www.tuxsoft.de.vu ]
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next reply other threads:[~2004-02-24 20:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-24 20:26 Michael Buesch [this message]
2004-02-24 22:57 ` [PATCH] udev fix another buffer overrun Kay Sievers
2004-02-28 0:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200402242125.52122.mbuesch@freenet.de \
--to=mbuesch@freenet.de \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).