linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] clarify udevinfo device walk
@ 2004-03-01 23:52 Kay Sievers
  2004-03-02  0:09 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Kay Sievers @ 2004-03-01 23:52 UTC (permalink / raw)
  To: linux-hotplug

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

It seems that the long attribute list can confuse the user.
Se here we print a few words on top the attributes.

thanks,
Kay

[-- Attachment #2: 01-clarify-device-walk.patch --]
[-- Type: text/plain, Size: 814 bytes --]

===== udevinfo.c 1.14 vs edited =====
--- 1.14/udevinfo.c	Wed Feb 25 01:04:14 2004
+++ edited/udevinfo.c	Tue Mar  2 00:46:03 2004
@@ -148,7 +148,14 @@
 		retval = -1;
 		goto exit;
 	}
-	printf("\ndevice '%s' has major:minor %s", class_dev->path, attr->value);
+
+	printf("\nudevinfo starts with the device the node belongs to and then walks up the\n"
+	       "device chain to print for every device found all possibly useful attributes\n"
+	       "in the udev key format.\n"
+	       "Only attributes within one device section may be used in a rule to match the\n"
+	       "device for which the node will be created.\n"
+	       "\n");
+	printf("device '%s' has major:minor %s", class_dev->path, attr->value);
 	sysfs_close_attribute(attr);
 
 	/* open sysfs class device directory and print all attributes */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] clarify udevinfo device walk
  2004-03-01 23:52 [PATCH] clarify udevinfo device walk Kay Sievers
@ 2004-03-02  0:09 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2004-03-02  0:09 UTC (permalink / raw)
  To: linux-hotplug

On Tue, Mar 02, 2004 at 12:52:37AM +0100, Kay Sievers wrote:
> It seems that the long attribute list can confuse the user.
> Se here we print a few words on top the attributes.

Applied, thanks.

greg k-h


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-03-02  0:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-03-01 23:52 [PATCH] clarify udevinfo device walk Kay Sievers
2004-03-02  0:09 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).