Re: [PATCH] cleanup udevstart

[Greg KH <greg@kroah.com>]

On Wed, Mar 03, 2004 at 12:23:56AM +0100, Olaf Hering wrote:
>  On Tue, Mar 02, Greg KH wrote:
> 
> > On Wed, Mar 03, 2004 at 12:09:51AM +0100, Olaf Hering wrote:
> > >  On Tue, Mar 02, Kay Sievers wrote:
> > > 
> > > > +#define SYSBLOCK		"/sys/block"
> > > > +#define SYSCLASS		"/sys/class"
> > > > +#define UDEV_BIN		"/sbin/udev"
> > > 
> > > >  	pid = fork();
> > > 
> > > > -		retval = execl("/sbin/udev", "/sbin/udev", path, NULL);
> > > 
> > > I have not looked closer at it, wouldnt it be better to feed the udevdb
> > > directly, instead of spawning countless udev processes? Some sort of
> > > udev binary which takes optional directories as agument to limit it to
> > > these sysfs dirs.
> > 
> > Nah, it's simpler this way.  We spawn and then wait, so there isn't a
> > zillion udev processes all running at once :)
> 
> thats the point, wait for what?
> I hope the whole point is to create all nodes in a jiffy, in the long run?

At startup we have to wait as usually the next thing the initscripts do
is use those device nodes.  So we have to wait until they are all
created.

And it's fast today.  Have you timed udevstart (or even the start_udev
bash script)?  Here's my box as I do a kernel build in the background at
the same time:

# /usr/bin/time /sbin/udevstart 
Command exited with non-zero status 22
0.19user 0.67system 0:01.04elapsed 83%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (2major+6065minor)pagefaults 0swaps

1 second to populate a full /dev while the system is under a very heavy
load is pretty good I think :)

thanks,

greg k-h


-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel