From: Chris Larson <kergoth@handhelds.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [patch] automatically install correct initscript
Date: Wed, 03 Mar 2004 18:46:08 +0000 [thread overview]
Message-ID: <20040303184608.GE12971@rikers.org> (raw)
In-Reply-To: <1078188416.10733.44.camel@localhost>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
* Robert Love (rml@ximian.com) wrote:
> On Mon, 2004-03-01 at 20:08, Robert Love wrote:
>
> > Ack, I did not even see that! Thanks.
> >
> > Let's rip that out, and always use the new built-in logic to determine
> > what initscript to install.
>
> Hm, looks like we do not need the %{lsb} and USE_LSB logic at all,
> anymore.
>
> Here is the patch, updated, removing both completely.
[snip]
> + @if [ -f /etc/redhat-release ]; then \
> + $(INSTALL_DATA) etc/init.d/udev $(etcdir)/init.d/udev; \
> + elif [ -f /etc/SuSE-release ]; then \
> + $(INSTALL_DATA) etc/init.d/udev.init.LSB $(etcdir)/init.d/udev; \
> + elif [ -f /etc/debian_version ]; then \
> + $(INSTALL_DATA) etc/init.d/udev.debian $(etcdir)/init.d/udev; \
> + fi
[snip]
Speaking as a package and distribution maintainer and all around CM and
build guy, there are two problems I feel the need to point out. First,
you're installing into $(etcdir) directly. Bad, Bad, Bad. -always-
obey DESTDIR. -always-. Second, the distro I'm installing into isn't
necessarily the distro I'm building on. Any opposition to making the
tests obey DESTDIR as well?
--
Chris Larson - kergoth at handhelds dot org
Embedded Linux Developer - clarson at ti dot com
OpenZaurus Project Maintainer - http://openzaurus.org/
[-- Attachment #2: fix-initscriptinstall-destdir.patch --]
[-- Type: text/plain, Size: 1077 bytes --]
#
# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
#
--- udev-019/Makefile~fix-initscriptinstall-destdir 2004-03-03 03:41:41.000000000 -0500
+++ udev-019/Makefile 2004-03-03 03:43:16.000000000 -0500
@@ -342,12 +342,12 @@
endif
install-initscript: etc/init.d/udev etc/init.d/udev.debian etc/init.d/udev.init.LSB
- @if [ -f /etc/redhat-release ]; then \
- $(INSTALL_DATA) etc/init.d/udev $(etcdir)/init.d/udev; \
- elif [ -f /etc/SuSE-release ]; then \
- $(INSTALL_DATA) etc/init.d/udev.init.LSB $(etcdir)/init.d/udev; \
- elif [ -f /etc/debian_version ]; then \
- $(INSTALL_DATA) etc/init.d/udev.debian $(etcdir)/init.d/udev; \
+ @if [ -f $(DESTDIR)/etc/redhat-release ]; then \
+ $(INSTALL_DATA) etc/init.d/udev $(DESTDIR)$(etcdir)/init.d/udev; \
+ elif [ -f $(DESTDIR)/etc/SuSE-release ]; then \
+ $(INSTALL_DATA) etc/init.d/udev.init.LSB $(DESTDIR)$(etcdir)/init.d/udev; \
+ elif [ -f $(DESTDIR)/etc/debian_version ]; then \
+ $(INSTALL_DATA) etc/init.d/udev.debian $(DESTDIR)$(etcdir)/init.d/udev; \
fi
install-config: $(GEN_CONFIGS)
next prev parent reply other threads:[~2004-03-03 18:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 0:46 [patch] automatically install correct initscript Robert Love
2004-03-02 1:04 ` Kay Sievers
2004-03-02 1:08 ` Robert Love
2004-03-02 1:14 ` Kay Sievers
2004-03-02 1:23 ` Robert Love
2004-03-02 20:28 ` Greg KH
2004-03-03 18:46 ` Chris Larson [this message]
2004-03-03 19:10 ` Greg KH
2004-03-03 19:21 ` Chris Larson
2004-03-03 19:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040303184608.GE12971@rikers.org \
--to=kergoth@handhelds.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).