From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Wed, 03 Mar 2004 19:36:32 +0000 Subject: Re: [patch] automatically install correct initscript Message-Id: <20040303193630.GA28198@kroah.com> List-Id: References: <1078188416.10733.44.camel@localhost> In-Reply-To: <1078188416.10733.44.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Wed, Mar 03, 2004 at 01:21:34PM -0600, Chris Larson wrote: > * Greg KH (greg@kroah.com) wrote: > > On Wed, Mar 03, 2004 at 12:46:08PM -0600, Chris Larson wrote: > > > Speaking as a package and distribution maintainer and all around CM and > > > build guy, there are two problems I feel the need to point out. First, > > > you're installing into $(etcdir) directly. Bad, Bad, Bad. -always- > > > obey DESTDIR. -always-. Second, the distro I'm installing into isn't > > > necessarily the distro I'm building on. Any opposition to making the > > > tests obey DESTDIR as well? > > > > I already made this change in the 021 release. > > Oh good, glad to hear it. > > > As for the cross-distro install issue, do you have any suggestions? > > Well, how about something as simple as using a makefile variable that > contains the name of the initscript to be installed, so that it can be > easily overridden by those building it? Sounds good to me, care to write a patch? :) thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel