udev 021 patches 2/2

udev 021 patches 2/2

[Marco d'Itri]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

udevstart_no_retval: currently udevstart will always return rc=22
because of the error handling code. I completely removed it because it
is not used, and returning a generic error to the init script is not
much useful anyway.

-- 
ciao, |
Marco | [4887 acJDyXc7CrEPQ]

[-- Attachment #2: udevstart_no_retval --]
[-- Type: text/plain, Size: 715 bytes --]

diff -ruNp udev-021.orig/udevstart.c udev-021/udevstart.c
--- udev-021.orig/udevstart.c	2004-03-03 01:01:33.000000000 +0100
+++ udev-021/udevstart.c	2004-03-03 15:41:34.000000000 +0100
@@ -78,12 +78,11 @@ static void udev_exec(const char *path, 
 	}
 }
 
-static int udev_scan(void)
+static void udev_scan(void)
 {
 	char *devpath;
 	DIR *dir;
 	struct dirent *dent;
-	int retval = -EINVAL;
 
 	devpath = "block";
 	dir = opendir(SYSBLOCK);
@@ -179,11 +178,6 @@ static int udev_scan(void)
 			}
 		}
 	}
-
-	if (retval > 0)
-		retval = 0;
-
-	return -retval;
 }
 
 
@@ -191,5 +185,7 @@ int main(int argc, char **argv, char **e
 {
 	init_logging("udevstart");
 
-	return udev_scan();
+	udev_scan();
+
+	return 0;
 }

Re: udev 021 patches 2/2

[Greg KH]

On Thu, Mar 04, 2004 at 02:15:21AM +0100, Marco d'Itri wrote:
> udevstart_no_retval: currently udevstart will always return rc"
> because of the error handling code. I completely removed it because it
> is not used, and returning a generic error to the init script is not
> much useful anyway.

Applied, thanks.

Does this sync udev up with all outstanding Debian patches?

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udev 021 patches 2/2

[Marco d'Itri]

On Mar 04, Greg KH <greg@kroah.com> wrote:

 >Does this sync udev up with all outstanding Debian patches?
Yes. I also have a scsi-devfs.sh script but I did not submit it because
I could not personally test it much.
I still have to find some time to make a generic udev.permissions.

BTW, I uploaded udev to unstable a few days ago and it should be
available in testing by next week.

-- 
ciao, |
Marco | [4910 sowI0xx7Q1IoA]


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udev 021 patches 2/2

[Greg KH]

On Thu, Mar 04, 2004 at 08:37:12PM +0100, Marco d'Itri wrote:
> On Mar 04, Greg KH <greg@kroah.com> wrote:
> 
>  >Does this sync udev up with all outstanding Debian patches?
> Yes. I also have a scsi-devfs.sh script but I did not submit it because
> I could not personally test it much.
> I still have to find some time to make a generic udev.permissions.
> 
> BTW, I uploaded udev to unstable a few days ago and it should be
> available in testing by next week.

Great, glad to hear this.

thanks for all of your udev packaging work.

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel