From: Patrick Mansfield <patmans@us.ibm.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] cleanup udevstart
Date: Tue, 16 Mar 2004 22:24:29 +0000 [thread overview]
Message-ID: <20040316142429.A1760@beaverton.ibm.com> (raw)
In-Reply-To: <20040302215536.GA12039@vrfy.org>
On Tue, Mar 16, 2004 at 10:57:55PM +0100, Kay Sievers wrote:
> On Tue, 2004-03-16 at 18:01, Patrick Mansfield wrote:
> > On Tue, Mar 16, 2004 at 03:49:51AM +0100, Kay Sievers wrote:
>
> Yes, I know. It was just a quick hack. I tried to avoid putting "normal"
> functions into a header file. If we want this to go in, we may create a
> udev_lib.[hc] or something and put in all the generic stuff currently in
> udev.h.
udev_lib sounds good, I created a udev-other.c.
> Much thanks for your measurements. It's always better to have real
> numbers :)
Well they are still not real disks. I assume we have even less of an issue
using real disks, as IO times increase and the hotplug and udev overhead
becomes a smaller percentage.
> It seeems that we need to fix it. The mmap() difference for glibc is
> pretty small, so it should also be possible to fix the fgets() in klibc.
> Any suggestion to go with mmap() or fix klibc instead?
IMO klibc should buffer fgets() no matter what udev uses.
So fix klibc and use its fgets, and if that can't happen soon use your
mmap patch.
-- Patrick Mansfield
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2004-03-16 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 21:55 [PATCH] cleanup udevstart Kay Sievers
2004-03-02 22:16 ` Greg KH
2004-03-02 23:09 ` Olaf Hering
2004-03-02 23:20 ` Greg KH
2004-03-02 23:23 ` Olaf Hering
2004-03-02 23:32 ` Greg KH
2004-03-15 21:22 ` Olaf Hering
2004-03-16 1:28 ` Kay Sievers
2004-03-16 2:49 ` Kay Sievers
2004-03-16 17:01 ` Patrick Mansfield
2004-03-16 21:57 ` Kay Sievers
2004-03-16 22:24 ` Patrick Mansfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316142429.A1760@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).