From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Mansfield Date: Tue, 16 Mar 2004 22:24:29 +0000 Subject: Re: [PATCH] cleanup udevstart Message-Id: <20040316142429.A1760@beaverton.ibm.com> List-Id: References: <20040302215536.GA12039@vrfy.org> In-Reply-To: <20040302215536.GA12039@vrfy.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, Mar 16, 2004 at 10:57:55PM +0100, Kay Sievers wrote: > On Tue, 2004-03-16 at 18:01, Patrick Mansfield wrote: > > On Tue, Mar 16, 2004 at 03:49:51AM +0100, Kay Sievers wrote: > > Yes, I know. It was just a quick hack. I tried to avoid putting "normal" > functions into a header file. If we want this to go in, we may create a > udev_lib.[hc] or something and put in all the generic stuff currently in > udev.h. udev_lib sounds good, I created a udev-other.c. > Much thanks for your measurements. It's always better to have real > numbers :) Well they are still not real disks. I assume we have even less of an issue using real disks, as IO times increase and the hotplug and udev overhead becomes a smaller percentage. > It seeems that we need to fix it. The mmap() difference for glibc is > pretty small, so it should also be possible to fix the fgets() in klibc. > Any suggestion to go with mmap() or fix klibc instead? IMO klibc should buffer fgets() no matter what udev uses. So fix klibc and use its fgets, and if that can't happen soon use your mmap patch. -- Patrick Mansfield ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel