[PATCH] uninitialized variable for mknod and friend

[PATCH] uninitialized variable for mknod and friend

[Olaf Hering]

mknod gets an uninitialized variable, which leads to interesting file
modes. the bug is in namedev, devices with no match must not use the
uninitialized stuff were dev points to.


--- udev-glibc/namedev.c        2004-03-18 14:35:19.000000000 +0000
+++ udev-glibc-debug/namedev.c  2004-03-18 16:31:41.000000000 +0000
@@ -840,12 +840,12 @@ found:
        apply_format(udev, udev->symlink, sizeof(udev->symlink), class_dev, sysfs_device);
        udev->partitions = dev->partitions;

-done:  
        /* get permissions given in rule */
        set_empty_perms(udev, dev->mode,
                              dev->owner,
                              dev->group);

+done:  
        /* get permissions given in config file or set defaults */
        perm = find_perm(udev->name);
        if (perm != NULL) {



-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, n√úRNBERG


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&opÃk
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] uninitialized variable for mknod and friend

[Greg KH]

On Thu, Mar 18, 2004 at 05:37:20PM +0100, Olaf Hering wrote:
> 
> mknod gets an uninitialized variable, which leads to interesting file
> modes. the bug is in namedev, devices with no match must not use the
> uninitialized stuff were dev points to.

Good catch.  Thanks, I've applied this.

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel