From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Tue, 23 Mar 2004 22:42:37 +0000 Subject: Re: udevinfo patch Message-Id: <20040323224237.GA26323@vrfy.org> List-Id: References: <20040323215101.GA30721@us.ibm.com> In-Reply-To: <20040323215101.GA30721@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, Mar 23, 2004 at 01:51:01PM -0800, Daniel Stekloff wrote: > > > Hi Greg, > > I think this is what you want for udevinfo. Patched against the latest BK > tree. I tested it and it seemed to work. Hey, thanks for fixing this. I always wanted to ask why I needed to comment out the close() calls. Beeing lazy sometimes seems to work well :) > One other question, shouldn't udevinfo.c:print_all_attributes() check to > make sure attr->method is SYSFS_METHOD_SHOW along with checking to see > if attr->value != NULL or doesn't that matter? Seems that the value is always NULL, if the file does not have read permissions. The sysfs_read_attribute() which sets the value is not called if SYSFS_METHOD_SHOW is not valid. thanks again, Kay ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel