From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] dev_d.c file sorting and cleanup
Date: Sat, 27 Mar 2004 01:08:02 +0000 [thread overview]
Message-ID: <20040327010801.GC13836@kroah.com> (raw)
In-Reply-To: <20040325134350.GA30182@vrfy.org>
Looks good except for:
On Thu, Mar 25, 2004 at 02:43:50PM +0100, Kay Sievers wrote:
> + /* look for file with specified suffix */
> + ext = strrchr(ent->d_name, '.');
> + if (ext = NULL)
> + continue;
> +
> + if (strcmp(ext, suffix) != 0)
> + continue;
That would still execute files named "foo.dev.rpmsave" right? That's
what we want to avoid happening. We need to make sure we match "*.dev$"
only.
So I'll hold off applying this for now.
thanks,
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-03-27 1:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-25 13:43 [PATCH] dev_d.c file sorting and cleanup Kay Sievers
2004-03-27 1:08 ` Greg KH [this message]
2004-03-27 1:13 ` Kay Sievers
2004-03-27 1:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040327010801.GC13836@kroah.com \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).