From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sat, 27 Mar 2004 01:08:02 +0000 Subject: Re: [PATCH] dev_d.c file sorting and cleanup Message-Id: <20040327010801.GC13836@kroah.com> List-Id: References: <20040325134350.GA30182@vrfy.org> In-Reply-To: <20040325134350.GA30182@vrfy.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org Looks good except for: On Thu, Mar 25, 2004 at 02:43:50PM +0100, Kay Sievers wrote: > + /* look for file with specified suffix */ > + ext = strrchr(ent->d_name, '.'); > + if (ext = NULL) > + continue; > + > + if (strcmp(ext, suffix) != 0) > + continue; That would still execute files named "foo.dev.rpmsave" right? That's what we want to avoid happening. We need to make sure we match "*.dev$" only. So I'll hold off applying this for now. thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel