From: Arkadiusz Miskiewicz <arekm@pld-linux.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: bashizm in hotplug scripts (including 20040401)
Date: Fri, 02 Apr 2004 13:05:32 +0000 [thread overview]
Message-ID: <200404021505.32878.arekm@pld-linux.org> (raw)
In-Reply-To: <200404020211.45303.arekm@pld-linux.org>
Dnia Friday 02 of April 2004 03:09, Martin Schwenke napisa³:
> Yuck! In section 2.6.4, the standard says:
>
> Only the decimal-constant, octal-constant, and hexadecimal-constant
> constants specified in the ISO C standard, Section 6.4.4.1 are
> required to be recognised as constants.
Missed that :/
> Arkadiusz> [...] but for example on pdksh run in sh mode it
> Arkadiusz> overflows - example:
>
> Arkadiusz> [arekm@mobarm arekm]$ echo $((16#ff))
> Arkadiusz> 255
> Arkadiusz> [arekm@mobarm arekm]$ echo $((16#ffffffff))
> Arkadiusz> -1
>
> Debian's ash-0.4.25 overflows too.
>
> Note that POSIX says:
>
> Only signed long integer arithmetic is required.
So hotplug scripts still need the change because they do arithmetic beyond
signed long:
[misiek@arm ~/rpm/SOURCES/hotplug-2004_04_01.org]$ grep -r 0xffffffff .
./etc/hotplug/pci.agent:PCI_ANY=$((0xffffffff))
> Looks like the best way of fixing this is to leave hotplug the way it
> is (except if a workaround for the overlows is needed)
It's needed. Either create some workaround or put #!/bin/bash there. Any
propositions for workaround?
> and fix
> pdksh... :-)
http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/pdksh-hex.patch?rev=1.1 from
OpenBSD people
> peace & happiness,
> martin
--
Arkadiusz Mi¶kiewicz CS at FoE, Wroclaw University of Technology
arekm.pld-linux.org, 1024/3DB19BBD, JID: arekm.jabber.org, PLD/Linux
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&opÌk
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-04-02 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-02 0:11 bashizm in hotplug scripts (including 20040401) Arkadiusz Miskiewicz
2004-04-02 1:09 ` Martin Schwenke
2004-04-02 13:05 ` Arkadiusz Miskiewicz [this message]
2004-04-05 6:06 ` Martin Schwenke
2004-04-05 17:11 ` Greg KH
2004-04-05 17:46 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200404021505.32878.arekm@pld-linux.org \
--to=arekm@pld-linux.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).