From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] handle netdev in udevruler
Date: Fri, 02 Apr 2004 18:29:24 +0000 [thread overview]
Message-ID: <20040402182924.GA17496@vrfy.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 161 bytes --]
Here we get the netdev handling for udevruler, after all information
is available now in the udev database. It also fixes the way libsysfs is
used.
thanks,
Kay
[-- Attachment #2: 01-udevruler-netdev.patch --]
[-- Type: text/plain, Size: 1888 bytes --]
===== udevruler.c 1.3 vs edited =====
--- 1.3/udevruler.c Sun Mar 28 18:33:33 2004
+++ edited/udevruler.c Fri Apr 2 20:26:23 2004
@@ -222,6 +222,7 @@
}
}
+ sysfs_close_directory(sysfs_dir);
return 0;
}
@@ -229,7 +230,6 @@
{
struct sysfs_class_device *class_dev;
struct sysfs_class_device *class_dev_parent;
- struct sysfs_attribute *attr;
struct sysfs_device *sysfs_dev;
struct sysfs_device *sysfs_dev_parent;
char key[NAME_SIZE];
@@ -246,16 +246,6 @@
return -1;
}
- /* read the 'dev' file for major/minor*/
- attr = sysfs_get_classdev_attr(class_dev, "dev");
- if (attr == NULL) {
- dbg("couldn't get the \"dev\" file");
- retval = -1;
- goto exit;
- }
-
- sysfs_close_attribute(attr);
-
/* open sysfs class device directory and get all attributes */
if (add_all_attributes(class_dev->path, level) != 0) {
dbg("couldn't open class device directory");
@@ -266,11 +256,10 @@
/* get the device link (if parent exists look here) */
class_dev_parent = sysfs_get_classdev_parent(class_dev);
- if (class_dev_parent != NULL) {
- //sysfs_close_class_device(class_dev);
- class_dev = class_dev_parent;
- }
- sysfs_dev = sysfs_get_classdev_device(class_dev);
+ if (class_dev_parent != NULL)
+ sysfs_dev = sysfs_get_classdev_device(class_dev_parent);
+ else
+ sysfs_dev = sysfs_get_classdev_device(class_dev);
/* look the device chain upwards */
while (sysfs_dev != NULL) {
@@ -290,13 +279,11 @@
if (sysfs_dev_parent == NULL)
break;
- //sysfs_close_device(sysfs_dev);
sysfs_dev = sysfs_dev_parent;
}
- sysfs_close_device(sysfs_dev);
exit:
- //sysfs_close_class_device(class_dev);
+ sysfs_close_class_device(class_dev);
return retval;
}
@@ -403,7 +390,7 @@
int i;
int numitems;
struct attribute **selattr;
- char text_rule[80];
+ char text_rule[255];
answer = newtRunForm(form);
if (answer == quit)
next reply other threads:[~2004-04-02 18:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-02 18:29 Kay Sievers [this message]
2004-04-02 22:16 ` [PATCH] handle netdev in udevruler Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040402182924.GA17496@vrfy.org \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).