From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Mon, 05 Apr 2004 17:11:22 +0000 Subject: Re: bashizm in hotplug scripts (including 20040401) Message-Id: <20040405171122.GA7287@kroah.com> List-Id: References: <200404020211.45303.arekm@pld-linux.org> In-Reply-To: <200404020211.45303.arekm@pld-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Mon, Apr 05, 2004 at 04:06:15PM +1000, Martin Schwenke wrote: > >>>>> "Arkadiusz" = Arkadiusz Miskiewicz writes: > > Arkadiusz> So hotplug scripts still need the change because they > Arkadiusz> do arithmetic beyond signed long: > > Arkadiusz> [...]$ grep -r 0xffffffff . > Arkadiusz> ./etc/hotplug/pci.agent:PCI_ANY=$((0xffffffff)) > > The value of PCI_ANY only ever compared against other things - there's > no useful arithmetic done. The PCI 2.2 specification only allows > Vendor ID and Device ID to be 16 bits (in configuration space at > least). If there any reason for using the value 0xffffffff, rather > than just 0xffff? Greg? Look at include/linux/mod_devicetable.h for why that is a 32 bit number (needs to match up with the pci_device_id fields.) Now why those fields are 32 bits, you will probably have to go dig through the 2.3 kernel archives, I don't remember anymore. thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel