From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arkadiusz Miskiewicz Date: Mon, 05 Apr 2004 17:46:14 +0000 Subject: Re: bashizm in hotplug scripts (including 20040401) Message-Id: <200404051946.14605.arekm@pld-linux.org> List-Id: References: <200404020211.45303.arekm@pld-linux.org> In-Reply-To: <200404020211.45303.arekm@pld-linux.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org Dnia Monday 05 of April 2004 08:06, Martin Schwenke napisa=B3: > The value of PCI_ANY only ever compared against other things - there's > no useful arithmetic done. The PCI 2.2 specification only allows > Vendor ID and Device ID to be 16 bits (in configuration space at > least). If there any reason for using the value 0xffffffff, rather > than just 0xffff? Greg? If 16 bits is max in reality then it seems that we don't have to do anythin= g=20 because: PCI_ANY=3D$((0xffffffff)) would overflow to -1 and=20 vendor=3D$(($vendor)); this will also overflow to -1 if [ $vendor -ne $PCI_ANY -a $vendor -ne $pci_id_vendor ]; then and we end up with -1 -ne -1 comparsion. Anyway comment about this should be added in hotplug scripts. > peace & happiness, > martin --=20 Arkadiusz Mi=B6kiewicz CS at FoE, Wroclaw University of Technology arekm.pld-linux.org, 1024/3DB19BBD, JID: arekm.jabber.org, PLD/Linux ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id638&op=CCk _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel