udev makefile patch

udev makefile patch

[Treeve Jelbert]

[-- Attachment #1: Type: Text/Plain, Size: 670 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I am part of the development team for SourceMage GNU/Linux

We now use udev as the default device manager, mounting on /dev


We had to make the attached changes to the Makefile, so that we could provide 
our own rules and permissions


I hope that this may of use to someone else





Regards,  Treeve 

- -- 
PGP Key ID: AB929B24
PGP Key Fingerprint:31D9 D22F 42E6 F545 662E  AB6F 9697 34C5 AB92 9B24 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAdYdTlpc0xauSmyQRAmWoAJ9DGsraounV8UYv3JYJuLsnVRyBVwCeOE8t
1y1ZOhI8dpLTVneqvt9BjTY=
=Ncxw
-----END PGP SIGNATURE-----

[-- Attachment #2: Makefile.patch --]
[-- Type: text/x-makefile, Size: 1253 bytes --]

--- Makefile	2004-04-03 12:20:04.000000000 +0200
+++ Makefile.cp	2004-04-03 12:26:20.000000000 +0200
@@ -109,7 +109,6 @@
 	OPTIMIZATION+=-fstrict-aliasing
 endif
 ifeq ($(strip $(TARGET_ARCH)),i386)
-	OPTIMIZATION+=-march=i386
 	OPTIMIZATION += ${shell if $(CC) -mpreferred-stack-boundary=2 -S -o /dev/null -xc \
 		/dev/null >/dev/null 2>&1; then echo "-mpreferred-stack-boundary=2"; fi}
 	OPTIMIZATION += ${shell if $(CC) -malign-functions=0 -malign-jumps=0 -S -o /dev/null -xc \
@@ -384,7 +383,7 @@
 	- rm $(mandir)/man8/udevd.8
 	- rm $(mandir)/man8/udevsend.8
 
-install: install-initscript install-config install-man install-dev.d all
+install: install-man install-dev.d all
 	$(INSTALL) -d $(DESTDIR)$(udevdir)
 	$(INSTALL) -d $(DESTDIR)$(hotplugdir)
 	$(INSTALL_PROGRAM) -D $(ROOT) $(DESTDIR)$(sbindir)/$(ROOT)
@@ -394,10 +393,6 @@
 	$(INSTALL_PROGRAM) -D $(TESTER) $(DESTDIR)$(usrbindir)/$(TESTER)
 	$(INSTALL_PROGRAM) -D $(STARTER) $(DESTDIR)$(sbindir)/$(STARTER)
 	- ln -f -s $(sbindir)/$(SENDER) $(DESTDIR)$(hotplugdir)/$(ROOT).hotplug
-ifndef DESTDIR
-	- killall udevd
-	- rm -f $(udevdir)/.udev.tdb
-endif
 	@extras="$(EXTRAS)" ; for target in $$extras ; do \
 		echo $$target ; \
 		$(MAKE) prefix=$(prefix) LD="$(LD)" SYSFS="$(SYSFS)" \

Re: udev makefile patch

[Greg KH]

On Thu, Apr 08, 2004 at 07:09:30PM +0200, Treeve Jelbert wrote:
> --- Makefile	2004-04-03 12:20:04.000000000 +0200
> +++ Makefile.cp	2004-04-03 12:26:20.000000000 +0200
> @@ -109,7 +109,6 @@
>  	OPTIMIZATION+=-fstrict-aliasing
>  endif
>  ifeq ($(strip $(TARGET_ARCH)),i386)
> -	OPTIMIZATION+=-march=i386

Why is this necessary?

>  	OPTIMIZATION += ${shell if $(CC) -mpreferred-stack-boundary=2 -S -o /dev/null -xc \
>  		/dev/null >/dev/null 2>&1; then echo "-mpreferred-stack-boundary=2"; fi}
>  	OPTIMIZATION += ${shell if $(CC) -malign-functions=0 -malign-jumps=0 -S -o /dev/null -xc \
> @@ -384,7 +383,7 @@
>  	- rm $(mandir)/man8/udevd.8
>  	- rm $(mandir)/man8/udevsend.8
>  
> -install: install-initscript install-config install-man install-dev.d all
> +install: install-man install-dev.d all

Why?  Doesn't your package manager handle this?

> -ifndef DESTDIR
> -	- killall udevd
> -	- rm -f $(udevdir)/.udev.tdb
> -endif

Again, why?  You should be setting DESTDIR if you are building for a
packagemanger, and if not, and you are building from scratch, into the
correct install directory, you really need to kill udevd.

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id\x1470&alloc_id638&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel