From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Thu, 08 Apr 2004 20:15:45 +0000 Subject: Re: udev makefile patch Message-Id: <20040408201545.GA12559@kroah.com> List-Id: References: <200404081909.41722.treeve01@pi.be> In-Reply-To: <200404081909.41722.treeve01@pi.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Thu, Apr 08, 2004 at 07:09:30PM +0200, Treeve Jelbert wrote: > --- Makefile 2004-04-03 12:20:04.000000000 +0200 > +++ Makefile.cp 2004-04-03 12:26:20.000000000 +0200 > @@ -109,7 +109,6 @@ > OPTIMIZATION+=-fstrict-aliasing > endif > ifeq ($(strip $(TARGET_ARCH)),i386) > - OPTIMIZATION+=-march=i386 Why is this necessary? > OPTIMIZATION += ${shell if $(CC) -mpreferred-stack-boundary=2 -S -o /dev/null -xc \ > /dev/null >/dev/null 2>&1; then echo "-mpreferred-stack-boundary=2"; fi} > OPTIMIZATION += ${shell if $(CC) -malign-functions=0 -malign-jumps=0 -S -o /dev/null -xc \ > @@ -384,7 +383,7 @@ > - rm $(mandir)/man8/udevd.8 > - rm $(mandir)/man8/udevsend.8 > > -install: install-initscript install-config install-man install-dev.d all > +install: install-man install-dev.d all Why? Doesn't your package manager handle this? > -ifndef DESTDIR > - - killall udevd > - - rm -f $(udevdir)/.udev.tdb > -endif Again, why? You should be setting DESTDIR if you are building for a packagemanger, and if not, and you are building from scratch, into the correct install directory, you really need to kill udevd. thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel