From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 09 Apr 2004 20:53:45 +0000 Subject: Re: [PATCH] call_usermodehelper hang Message-Id: <20040409205344.GA5236@kroah.com> List-Id: References: <4072F2B7.2070605@us.ibm.com> <20040406172903.186dd5f1.akpm@osdl.org> <20040407061146.GA10413@kroah.com> <407487A6.8020904@us.ibm.com> <20040408224713.GD15125@kroah.com> <40770AD0.4000402@us.ibm.com> In-Reply-To: <40770AD0.4000402@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Brian King Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-hotplug-devel@lists.sourceforge.net On Fri, Apr 09, 2004 at 03:42:56PM -0500, Brian King wrote: > Would you prefer a fix in call_usermodehelper itself? It could certainly > be argued that calling call_usermodehelper with wait=0 should be allowed > even when holding locks. Although, fixing it here is less obvious to me > how to do because of the arguments to call_usermodehelper. I would imagine > it would consist of creating a kernel_thread to preserve the caller's stack. Yes, I think call_usermodehelper should be changed to create a new kernel thread for every call. That would solve this problem, and any future races that might happen. Care to work on that? thanks, greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70&alloc_id638&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel