udev-test.pl failures

udev-test.pl failures

[Erik Harrison]

I pulled the .25 release of udev, and built it on Slackware 9.1 with a 
2.6.2 kernel. I get three failures. Here is the output of the failing tests.

TEST 69: big minor number test
device '/class/i2c-dev/i2c-300' expecting node 'node'
expected major:minor is: 89:300
created major:minor is : 89:44
major:minor: error    add: ok    remove: ok

TEST 70: big major number test
device '/class/i2c-dev/i2c-fake1' expecting node 'node'
expected major:minor is: 4095:1
created major:minor is : 255:1
major:minor: error    add: ok    remove: ok

TEST 71: big major and big minor number test
device '/class/i2c-dev/i2c-fake2' expecting node 'node'
expected major:minor is: 4094:89999
created major:minor is : 255:143
major:minor: error    add: ok    remove: ok

-Erik


-------------------------------------------------------
This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek
For a limited time only, get FREE Ground shipping on all orders of $35
or more. Hurry up and shop folks, this offer expires April 30th!
http://www.thinkgeek.com/freeshipping/?cpg\x12297
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udev-test.pl failures

[Kay Sievers]

On Thu, Apr 22, 2004 at 02:10:06PM -0400, Erik Harrison wrote:
> I pulled the .25 release of udev, and built it on Slackware 9.1 with a 
> 2.6.2 kernel. I get three failures. Here is the output of the failing tests.
> 
> TEST 69: big minor number test
> device '/class/i2c-dev/i2c-300' expecting node 'node'
> expected major:minor is: 89:300
> created major:minor is : 89:44
> major:minor: error    add: ok    remove: ok
> 
> TEST 70: big major number test
> device '/class/i2c-dev/i2c-fake1' expecting node 'node'
> expected major:minor is: 4095:1
> created major:minor is : 255:1
> major:minor: error    add: ok    remove: ok
> 
> TEST 71: big major and big minor number test
> device '/class/i2c-dev/i2c-fake2' expecting node 'node'
> expected major:minor is: 4094:89999
> created major:minor is : 255:143
> major:minor: error    add: ok    remove: ok

Seems your glibc doesn't suppport the large dev_t.
A compilation with klibc should work. (?)

Kay


-------------------------------------------------------
This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek
For a limited time only, get FREE Ground shipping on all orders of $35
or more. Hurry up and shop folks, this offer expires April 30th!
http://www.thinkgeek.com/freeshipping/?cpg\x12297
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: udev-test.pl failures

[Greg KH]

On Thu, Apr 22, 2004 at 02:10:06PM -0400, Erik Harrison wrote:
> I pulled the .25 release of udev, and built it on Slackware 9.1 with a 
> 2.6.2 kernel. I get three failures. Here is the output of the failing tests.
> 
> TEST 69: big minor number test
> device '/class/i2c-dev/i2c-300' expecting node 'node'
> expected major:minor is: 89:300
> created major:minor is : 89:44
> major:minor: error    add: ok    remove: ok

Upgrade your version of glibc :)

Or use klibc, it should handle it just fine.

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: The Robotic Monkeys at ThinkGeek
For a limited time only, get FREE Ground shipping on all orders of $35
or more. Hurry up and shop folks, this offer expires April 30th!
http://www.thinkgeek.com/freeshipping/?cpg\x12297
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

udev-test.pl failures

[Alan Jenkins]

commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
Author: Kay Sievers <kay.sievers@vrfy.org>
Date:   Mon Sep 15 17:12:47 2008 -0700

    libudev: switch API from devpath to syspath


Lots of the udev tests fail here.  udev_sysfs.c broke when
util_resolve_sys_link() switched API.  I'll leave this up to you - maybe
your next commit is going to do away with udev_sysfs.c altogether :-).

Regards
Alan

Re: udev-test.pl failures

[Kay Sievers]

On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958

> Lots of the udev tests fail here.  udev_sysfs.c broke when
> util_resolve_sys_link() switched API.

Ah, sorry, should be fixed now.

> I'll leave this up to you - maybe
> your next commit is going to do away with udev_sysfs.c altogether :-).

It will go away soon, yeah. We should get rid of udev_sysfs.c and
"struct udevice". The temporary rule processing variables and a
libudev's "struct udev_device" pointer should fit into the rule
iterator you added recently.

Kay

Re: udev-test.pl failures

[Kay Sievers]

On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers@vrfy.org> wrote:
> On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
>
>> Lots of the udev tests fail here.  udev_sysfs.c broke when
>> util_resolve_sys_link() switched API.
>
> Ah, sorry, should be fixed now.
>
>> I'll leave this up to you - maybe
>> your next commit is going to do away with udev_sysfs.c altogether :-).
>
> It will go away soon, yeah. We should get rid of udev_sysfs.c and
> "struct udevice".

Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
event environment is replaced by a per-device property list. The
daemon, and everything else uses the libudev code now.

It seems to work fine here, but the code may be a bit rough at the
moment, until it has seen more testing. But, it should be pretty easy
now to play around with a threaded version of the daemon.

Thanks,
Kay

Re: udev-test.pl failures

[Alan Jenkins]

Kay Sievers wrote:
> On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers@vrfy.org> wrote:
>   
>> On Tue, Sep 16, 2008 at 03:09, Alan Jenkins <alan-jenkins@tuffmail.co.uk> wrote:
>>     
>>> commit 8753fadf2a6ecead372e71b8bf9336cf29f9c958
>>>       
>>> Lots of the udev tests fail here.  udev_sysfs.c broke when
>>> util_resolve_sys_link() switched API.
>>>       
>> Ah, sorry, should be fixed now.
>>
>>     
>>> I'll leave this up to you - maybe
>>> your next commit is going to do away with udev_sysfs.c altogether :-).
>>>       
>> It will go away soon, yeah. We should get rid of udev_sysfs.c and
>> "struct udevice".
>>     
>
> Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
> event environment is replaced by a per-device property list. The
> daemon, and everything else uses the libudev code now.
>
> It seems to work fine here, but the code may be a bit rough at the
> moment, until it has seen more testing. But, it should be pretty easy
> now to play around with a threaded version of the daemon.
>
> Thanks,
> Kay
>   

Great.  I don't have so much time now though; I need to concentrate on
project work.

Going back to the original subject line... :-).  I see the tests still
pass, but some of them make suspicious noises now.

TEST 7: label test of max sysfs files
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
expecting node 'boot_disk1'
libudev: add_rule_key_pair: skip, too many keys of the same type in a
single rule                            
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'            
add:         ok
libudev: add_rule_key_pair: skip, too many keys of the same type in a
single rule                            
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'            
remove:      ok

TEST 19: Handle stupid backslashed multi lines in config file (and
replace kernel name)
device '/devices/pci0000:00/0000:00:1d.7/usb5/5-2/5-2:1.0/tty/ttyACM0'
expecting node 'modem'
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:4'
add:         ok
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:4'
remove:      ok

TEST 118: ENV{} test (assign2)
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
expecting node 'part'
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'      
add:        
ok                                                                                        

libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'      
remove:      ok

TEST 129: final assignment
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
expecting node 'ok'
libudev: lookup_group: specified group 'nobody'
unknown                                         
Argument "nobody" isn't numeric in numeric ne (!=) at ./udev-test.pl
line 1671.                   
permissions:
ok                                                                                   

add:        
ok                                                                                   

remove:      ok

TEST 144: overlong comment line
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
expecting node 'yes'
libudev: add_to_rules: invalid KERNEL
operation                                                       
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'     
add:        
ok                                                                                       

libudev: add_to_rules: invalid KERNEL
operation                                                       
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'
remove:      ok

TEST 146: TEST absolute path
device
'/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
expecting node 'there'
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'
add:         ok
libudev: add_to_rules: invalid rule
'/home/alan/Documents/bootup/src/udev/test/udev-test.rules:1'
remove:      ok

Re: udev-test.pl failures

[Kay Sievers]

On Fri, Oct 17, 2008 at 10:49 AM, Alan Jenkins
<alan-jenkins@tuffmail.co.uk> wrote:
> Kay Sievers wrote:
>> On Tue, Sep 16, 2008 at 7:16 PM, Kay Sievers <kay.sievers@vrfy.org> wrote:
>> Along with a lot of other stuff, udev_sysfs.c is gone. Also the global
>> event environment is replaced by a per-device property list. The
>> daemon, and everything else uses the libudev code now.
>>
>> It seems to work fine here, but the code may be a bit rough at the
>> moment, until it has seen more testing. But, it should be pretty easy
>> now to play around with a threaded version of the daemon.

> Great.  I don't have so much time now though; I need to concentrate on
> project work.
>
> Going back to the original subject line... :-).  I see the tests still
> pass, but some of them make suspicious noises now.
>
> TEST 7: label test of max sysfs files
> device
> '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
> expecting node 'boot_disk1'
> libudev: add_rule_key_pair: skip, too many keys of the same type in a single rule

That's valid, we ignore that rule. Added note to the test description.

> TEST 19: Handle stupid backslashed multi lines in config file (and replace kernel name)
> device '/devices/pci0000:00/0000:00:1d.7/usb5/5-2/5-2:1.0/tty/ttyACM0'
> expecting node 'modem'
> libudev: add_to_rules: invalid rule

We do not support backslash backslash, only backslash newline, I
removed the second backslash one from the test.

> TEST 118: ENV{} test (assign2)
> device
> '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
> expecting node 'part'
> libudev: add_to_rules: invalid rule

A rule with just unconditionally NAME= is invalid in the current
logic, it's from the time before we had GOTO. :) I've added a
SUBSYSTEM= match.

> TEST 129: final assignment
> device '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
> expecting node 'ok'
> libudev: lookup_group: specified group 'nobody'

Your system does not have group "nobody", I changed it to "tty".

> TEST 144: overlong comment line
> device '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda/sda1'
> expecting node 'yes'
> libudev: add_to_rules: invalid KERNEL operation

KERNEL="" can not work, it can only be matched. Fixed in the test.

> TEST 146: TEST absolute path
> device '/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/block/sda'
> expecting node 'there'
> libudev: add_to_rules: invalid rule

Same as 118, I removed the NAME= only rule, and added a new test which
will just cover this case.

Thanks,
Kay