From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] evaluate getenv() return value for udev_config.c
Date: Fri, 14 May 2004 22:20:53 +0000 [thread overview]
Message-ID: <20040514222053.GC16180@kroah.com> (raw)
In-Reply-To: <1084493953.12420.110.camel@ibm-d.pdx.osdl.net>
On Thu, May 13, 2004 at 05:19:13PM -0700, Leann Ogasawara wrote:
> Hi All,
>
> Small patch to fix the evaluation logic for the return value of getenv()
> in udev_config.c file. Basically, the actual values for the environment
> variables "UDEV_NO_SLEEP" and "UDEV_NO_DEVD" were not being checked.
> For example UDEV_NO_SLEEP could have been set to false but the line:
>
> if (getenv("UDEV_NO_SLEEP") != NULL)
>
> in this case would always evaluate to true, since getenv() returns
> char*, thus the "udev_sleep" variable would be set incorrectly. The
> patch makes sure to check the value returned by getenv() not just if
> getenv() returned a value. Hope this made sense. Thanks,
>
> Leann
>
> Should apply cleanly to last udev tree (version 025 I believe).
Applied, thanks.
greg k-h
-------------------------------------------------------
This SF.Net email is sponsored by: SourceForge.net Broadband
Sign-up now for SourceForge Broadband and get the fastest
6.0/768 connection for only $19.95/mo for the first 3 months!
http://ads.osdn.com/?ad_id%62&alloc_ida84&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2004-05-14 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 0:19 [PATCH] evaluate getenv() return value for udev_config.c Leann Ogasawara
2004-05-14 22:20 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040514222053.GC16180@kroah.com \
--to=greg@kroah.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).