From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 14 May 2004 22:20:53 +0000 Subject: Re: [PATCH] evaluate getenv() return value for udev_config.c Message-Id: <20040514222053.GC16180@kroah.com> List-Id: References: <1084493953.12420.110.camel@ibm-d.pdx.osdl.net> In-Reply-To: <1084493953.12420.110.camel@ibm-d.pdx.osdl.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Thu, May 13, 2004 at 05:19:13PM -0700, Leann Ogasawara wrote: > Hi All, > > Small patch to fix the evaluation logic for the return value of getenv() > in udev_config.c file. Basically, the actual values for the environment > variables "UDEV_NO_SLEEP" and "UDEV_NO_DEVD" were not being checked. > For example UDEV_NO_SLEEP could have been set to false but the line: > > if (getenv("UDEV_NO_SLEEP") != NULL) > > in this case would always evaluate to true, since getenv() returns > char*, thus the "udev_sleep" variable would be set incorrectly. The > patch makes sure to check the value returned by getenv() not just if > getenv() returned a value. Hope this made sense. Thanks, > > Leann > > Should apply cleanly to last udev tree (version 025 I believe). Applied, thanks. greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: SourceForge.net Broadband Sign-up now for SourceForge Broadband and get the fastest 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id%62&alloc_ida84&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel