Re: udev zombies

[Kay Sievers <kay.sievers@vrfy.org>]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Sun, Jun 06, 2004 at 01:16:05PM +0200, Michael Buesch wrote:
> On Sunday 06 June 2004 12:52, you wrote:
> > On Sun, Jun 06, 2004 at 12:08:09PM +0200, Michael Buesch wrote:
> > 
> > > And my zombie problem is still there. :)
> > > 
> > > And again: I'm using klibc. With glibc everything seems to work fine.
> > > (haven't checked the sig_handler() stuff, but at least there are no
> > > zombies)
> > 
> > Could you please test this patch. If this fixes the problem on your box,
> > I will look deeper into it.
> [SNIP]
> 
> Fixes both problems.

Michael, you were right, it was the signal handler. Good catch.
The problem was caused by using register- instead of the expected stack-
parameters for the signal handling function. Adding a attribute to prevent
the 'optimization', should fix it.

It would be great, if you are able to test it another time with the reenabled
regparms.

thanks,
Kay

[-- Attachment #2: 01-udev-regparm-fix.patch --]
[-- Type: text/plain, Size: 292 bytes --]

===== udevd.c 1.32 vs edited =====
--- 1.32/udevd.c	Fri May 21 06:13:45 2004
+++ edited/udevd.c	Sun Jun  6 14:18:23 2004
@@ -306,7 +306,7 @@
 	return;
 }
 
-static void sig_handler(int signum)
+__attribute__ ((regparm(0))) static void sig_handler(int signum)
 {
 	int rc;
 	switch (signum) {