From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Date: Sun, 06 Jun 2004 13:16:22 +0000 Subject: Re: udev zombies Message-Id: <20040606131622.GB15502@vrfy.org> MIME-Version: 1 Content-Type: multipart/mixed; boundary="5I6of5zJg18YgZEa" List-Id: References: <200406011914.13245.mbuesch@freenet.de> In-Reply-To: <200406011914.13245.mbuesch@freenet.de> To: linux-hotplug@vger.kernel.org --5I6of5zJg18YgZEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jun 06, 2004 at 01:16:05PM +0200, Michael Buesch wrote: > On Sunday 06 June 2004 12:52, you wrote: > > On Sun, Jun 06, 2004 at 12:08:09PM +0200, Michael Buesch wrote: > > > > > And my zombie problem is still there. :) > > > > > > And again: I'm using klibc. With glibc everything seems to work fine. > > > (haven't checked the sig_handler() stuff, but at least there are no > > > zombies) > > > > Could you please test this patch. If this fixes the problem on your box, > > I will look deeper into it. > [SNIP] > > Fixes both problems. Michael, you were right, it was the signal handler. Good catch. The problem was caused by using register- instead of the expected stack- parameters for the signal handling function. Adding a attribute to prevent the 'optimization', should fix it. It would be great, if you are able to test it another time with the reenabled regparms. thanks, Kay --5I6of5zJg18YgZEa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename="01-udev-regparm-fix.patch" ===== udevd.c 1.32 vs edited ===== --- 1.32/udevd.c Fri May 21 06:13:45 2004 +++ edited/udevd.c Sun Jun 6 14:18:23 2004 @@ -306,7 +306,7 @@ return; } -static void sig_handler(int signum) +__attribute__ ((regparm(0))) static void sig_handler(int signum) { int rc; switch (signum) { --5I6of5zJg18YgZEa-- ------------------------------------------------------- This SF.Net email is sponsored by the new InstallShield X. >From Windows to Linux, servers to mobile, InstallShield X is the one installation-authoring solution that does it all. Learn more and evaluate today! http://www.installshield.com/Dev2Dev/0504 _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel