[PATCH] Fix buffer overflow in udevstart

[PATCH] Fix buffer overflow in udevstart

[Hannes Reinecke]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Hi all,

this patch fixes a buffer overflow in udevstart. Quite nasty that it 
went overlooked for so long. Made our Opterons segfault.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

[-- Attachment #2: udev-029-max_pathlen.patch --]
[-- Type: text/x-patch, Size: 429 bytes --]

--- udev-029/udevstart.c.orig	2004-07-16 13:15:41.010532491 +0200
+++ udev-029/udevstart.c	2004-07-16 13:51:55.895068751 +0200
@@ -228,7 +228,7 @@
 				continue;
 
 			snprintf(dirname, MAX_PATHLEN, "%s/%s", SYSCLASS, dent->d_name);
-			dirname[MAX_PATHLEN] = '\0';
+			dirname[MAX_PATHLEN - 1] = '\0';
 			dir2 = opendir(dirname);
 			if (dir2 != NULL) {
 				for (dent2 = readdir(dir2); dent2 != NULL; dent2 = readdir(dir2)) {

Re: [PATCH] Fix buffer overflow in udevstart

[Greg KH]

On Fri, Jul 16, 2004 at 01:59:49PM +0200, Hannes Reinecke wrote:
> Hi all,
> 
> this patch fixes a buffer overflow in udevstart. Quite nasty that it 
> went overlooked for so long. Made our Opterons segfault.

Already fixed in the 030 release, but thanks anyway :)

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id\x10040&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel