From: Patrick Mansfield <patmans@us.ibm.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] restrict buffer size to 254 in scsi_id
Date: Fri, 30 Jul 2004 16:48:47 +0000 [thread overview]
Message-ID: <20040730164847.GA5197@beaverton.ibm.com> (raw)
In-Reply-To: <40FB9510.30309@suse.de>
On Mon, Jul 19, 2004 at 11:32:00AM +0200, Hannes Reinecke wrote:
> Hi all,
>
> this patch restricts the max buffer size to 254 in scsi_id. According to
> our SCSI-god-in-residence this is needed as some Wide-SCSI device might
> behave nasty if asked for odd lengths.
> We had a rather lengthy bugzilla for it and even Patrick agreed that
> this is a good thing.
> Patrick, is this correct? If so, could you also apply it for the scsi_id
> program?
Hannes -
Looks good, thanks.
I applied, only change was to remove what had been a dumb no-op if check in
scsi_get_serial, since the passed in buffer size can never be too large,
just too small.
There are some buffer sizes that should change to match the 254 (should
have just been a define), I'll change those.
-- Patrick Mansfield
-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2004-07-30 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-19 9:32 [PATCH] restrict buffer size to 254 in scsi_id Hannes Reinecke
2004-07-30 16:48 ` Patrick Mansfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040730164847.GA5197@beaverton.ibm.com \
--to=patmans@us.ibm.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).