From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Mansfield Date: Fri, 30 Jul 2004 16:48:47 +0000 Subject: Re: [PATCH] restrict buffer size to 254 in scsi_id Message-Id: <20040730164847.GA5197@beaverton.ibm.com> List-Id: References: <40FB9510.30309@suse.de> In-Reply-To: <40FB9510.30309@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Mon, Jul 19, 2004 at 11:32:00AM +0200, Hannes Reinecke wrote: > Hi all, > > this patch restricts the max buffer size to 254 in scsi_id. According to > our SCSI-god-in-residence this is needed as some Wide-SCSI device might > behave nasty if asked for odd lengths. > We had a rather lengthy bugzilla for it and even Patrick agreed that > this is a good thing. > Patrick, is this correct? If so, could you also apply it for the scsi_id > program? Hannes - Looks good, thanks. I applied, only change was to remove what had been a dumb no-op if check in scsi_get_serial, since the passed in buffer size can never be too large, just too small. There are some buffer sizes that should change to match the 254 (should have just been a define), I'll change those. -- Patrick Mansfield ------------------------------------------------------- This SF.Net email is sponsored by OSTG. Have you noticed the changes on Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now, one more big change to announce. We are now OSTG- Open Source Technology Group. Come see the changes on the new OSTG site. www.ostg.com _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel