linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
To: Daniel J Walsh <dwalsh@redhat.com>
Cc: Greg KH <greg@kroah.com>, Bill Nottingham <notting@redhat.com>,
	harald@redhat.com, SELinux <SELinux@tycho.nsa.gov>,
	"Fedora SELinux support list for users & developers."
	<fedora-selinux-list@redhat.com>,
	linux-hotplug-devel@lists.sourceforge.net
Subject: Re: Cleaned up udev-selinux patch
Date: Fri, 27 Aug 2004 15:42:00 +0000	[thread overview]
Message-ID: <20040827154200.GB4760@lkcl.net> (raw)
In-Reply-To: <412F37D2.7070105@redhat.com>

On Fri, Aug 27, 2004 at 09:32:02AM -0400, Daniel J Walsh wrote:

> Further cleanup and using all static inlines versus defines.  Renamed a 
> couple of functions to make them clearer.
 
> +}
> +static inline void selinux_setfilecon(char *file, unsigned int mode) { 
> +	if (is_selinux_running()) {
> +		security_context_t scontext=NULL;
> +		if (matchpathcon(file, mode, &scontext) < 0) {
> +			dbg("matchpathcon(%s) failed\n", file);
> +		} else {
> +			
> +			if (setfilecon(file, scontext) < 0)
> +				dbg("setfiles %s failed with error '%s'",
> +				    file, strerror(errno));
> +			freecon(scontext);
> +		}
> +	}
> +}
> +
> +static inline void selinux_setfscreatecon(char *file, unsigned int mode) {
> +	int retval = 0;
> +	security_context_t scontext=NULL;
> +
> +	if (is_selinux_running()) {
> +		if (matchpathcon(file, S_IFDIR, &scontext) < 0) {
                               ^^^^^^^

	this should be matchpathcon(file, mode, &scontext)


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idP47&alloc_id\x10808&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  reply	other threads:[~2004-08-27 15:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040223213614.GA12242@devserv.devel.redhat.com>
     [not found] ` <20040224233859.GA3265@kroah.com>
     [not found]   ` <20040224234652.GA14775@devserv.devel.redhat.com>
     [not found]     ` <403C8AE4.10403@redhat.com>
     [not found]       ` <20040228005300.GA13860@kroah.com>
     [not found]         ` <412DFE7B.6060409@redhat.com>
     [not found]           ` <20040826155716.GA30726@kroah.com>
2004-08-26 17:41             ` Cleaned up udev-selinux patch Daniel J Walsh
2004-08-26 17:51               ` Greg KH
2004-08-26 19:07                 ` Daniel J Walsh
2004-08-26 19:14                   ` Greg KH
2004-08-26 22:59                   ` Luke Kenneth Casson Leighton
2004-08-26 22:56                     ` Greg KH
2004-08-27 13:32                       ` Daniel J Walsh
2004-08-27 15:42                         ` Luke Kenneth Casson Leighton [this message]
2004-08-30 18:52                         ` Luke Kenneth Casson Leighton
2004-08-27 14:28                       ` Luke Kenneth Casson Leighton
2004-08-26 22:56               ` Luke Kenneth Casson Leighton
2004-08-27 15:36               ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040827154200.GB4760@lkcl.net \
    --to=lkcl@lkcl.net \
    --cc=SELinux@tycho.nsa.gov \
    --cc=dwalsh@redhat.com \
    --cc=fedora-selinux-list@redhat.com \
    --cc=greg@kroah.com \
    --cc=harald@redhat.com \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    --cc=notting@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).