From: Tom Rini <trini@kernel.crashing.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: [patch] Fix naming ethernet devices in udevstart
Date: Tue, 07 Sep 2004 22:54:11 +0000 [thread overview]
Message-ID: <20040907225411.GK20951@smtp.west.cox.net> (raw)
In-Reply-To: <20040907031839.GA20951@smtp.west.cox.net>
On Tue, Sep 07, 2004 at 10:23:50AM -0700, Tom Rini wrote:
> On Tue, Sep 07, 2004 at 06:56:49PM +0200, Kay Sievers wrote:
> > On Tue, Sep 07, 2004 at 12:46:43PM +0200, Kay Sievers wrote:
> > > On Mon, 2004-09-06 at 20:18 -0700, Tom Rini wrote:
> > > > I noticed somewhat recently that my enet devices weren't being renamed
> > > > on boot anymore. I don't quite know when this got broken (or rather, if
> > > > it was supposed to be working. I swear it worked for me once..), but
> > > > the following seems to do it.
> > >
> > > I think it never worked in the udevstart case. It worked only with the
> > > hotplug-event-udev, I expect.
> > >
> > > > In udev_scan_class(), look for not just
> > > > %s/%s/dev (which everything with a dev node has), but %s/%s/dev* (both
> > > > of my enet devices, sis900 & 3c59x only have device) and if that
> > > > exists, pass this along to udev.
> > >
> > > Yeah, network devices don't have a devnode and therefore no "dev", but
> > > they are all in /sys/class/net/. We may just test if we are there
> > > instead of the "device" match.
> >
> > How about something like this. It adds all the net devices without
> > looking at the attributes and keeps the remaining logic like it is.
>
> I'll give it a shot on my ppc_8xx board and if that's OK, I'll figure
> out how to give it a shot on gentoo and then my workstation
> (debian/unstable).
Tested on all 3 and worked fine.
--
Tom Rini
http://gate.crashing.org/~trini/
-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idP47&alloc_id\x10808&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2004-09-07 22:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 3:18 [patch] Fix naming ethernet devices in udevstart Tom Rini
2004-09-07 10:46 ` Kay Sievers
2004-09-07 16:56 ` Kay Sievers
2004-09-07 17:23 ` Tom Rini
2004-09-07 22:54 ` Tom Rini [this message]
2004-09-10 20:19 ` Greg KH
2004-09-10 20:21 ` Greg KH
2004-09-10 21:25 ` Kevin P. Fleming
2004-09-10 23:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040907225411.GK20951@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).