From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 07 Sep 2004 22:54:11 +0000 Subject: Re: [patch] Fix naming ethernet devices in udevstart Message-Id: <20040907225411.GK20951@smtp.west.cox.net> List-Id: References: <20040907031839.GA20951@smtp.west.cox.net> In-Reply-To: <20040907031839.GA20951@smtp.west.cox.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Tue, Sep 07, 2004 at 10:23:50AM -0700, Tom Rini wrote: > On Tue, Sep 07, 2004 at 06:56:49PM +0200, Kay Sievers wrote: > > On Tue, Sep 07, 2004 at 12:46:43PM +0200, Kay Sievers wrote: > > > On Mon, 2004-09-06 at 20:18 -0700, Tom Rini wrote: > > > > I noticed somewhat recently that my enet devices weren't being renamed > > > > on boot anymore. I don't quite know when this got broken (or rather, if > > > > it was supposed to be working. I swear it worked for me once..), but > > > > the following seems to do it. > > > > > > I think it never worked in the udevstart case. It worked only with the > > > hotplug-event-udev, I expect. > > > > > > > In udev_scan_class(), look for not just > > > > %s/%s/dev (which everything with a dev node has), but %s/%s/dev* (both > > > > of my enet devices, sis900 & 3c59x only have device) and if that > > > > exists, pass this along to udev. > > > > > > Yeah, network devices don't have a devnode and therefore no "dev", but > > > they are all in /sys/class/net/. We may just test if we are there > > > instead of the "device" match. > > > > How about something like this. It adds all the net devices without > > looking at the attributes and keeps the remaining logic like it is. > > I'll give it a shot on my ppc_8xx board and if that's OK, I'll figure > out how to give it a shot on gentoo and then my workstation > (debian/unstable). Tested on all 3 and worked fine. -- Tom Rini http://gate.crashing.org/~trini/ ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_idP47&alloc_id808&op=click _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel