From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 10 Sep 2004 20:03:23 +0000 Subject: Re: [PATCH] udev - read long lines from config files overflow fix Message-Id: <20040910200323.GA19444@kroah.com> List-Id: References: <20040904170854.GA12270@spock.enterprise> In-Reply-To: <20040904170854.GA12270@spock.enterprise> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-hotplug@vger.kernel.org On Mon, Sep 06, 2004 at 02:28:11AM +0800, Arun Bhanu wrote: > Hi Kay, > > On 23:12 Sat 04 Sep , Kay Sievers wrote: > > Cool, a real bug :) > > Thanks, for the patch. I think it would be better to skip lenghth exceeding > > lines instead of cutting it and continue. While looking at it I restructured > > the buffer reading logic a bit and fixed another stupid bug. > Thanks for the cleanup. > > You may have overlooked the fix for udev_config.c(parsing udev.conf) in > your patch. So, I've adapted the fixes you applied to namedev_parse.c > to this file also. > > Also, while 'eating' the whitespace the 'count' doesn't get decremented. > This leads strncpy to copy the number of whitespace minus 1 characters > from the next line. Minus 1 because it copies '\n' from the current > line. > > while (isspace(bufline[0])) { > bufline++; > + count--; > } > . > . > . > strncpy(line, bufline, count); > > Included patch(against udev-030) contains the above fixes as well as > your fixes. Applied, thanks. greg k-h ------------------------------------------------------- This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 Project Admins to receive an Apple iPod Mini FREE for your judgement on who ports your project to Linux PPC the best. Sponsored by IBM. Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel