Re: Problems using scsi_id with udevstart

[Greg KH <greg@kroah.com>]

On Wed, Oct 06, 2004 at 11:39:17PM +0200, Kay Sievers wrote:
> On Wed, Oct 06, 2004 at 03:22:03PM -0600, Andrew Patterson wrote:
> > On Wed, 2004-10-06 at 21:13 +0200, Kay Sievers wrote:
> > > On Wed, 2004-10-06 at 12:42 -0600, Andrew Patterson wrote:
> > > > On Wed, 2004-10-06 at 09:59 -0700, Patrick Mansfield wrote:
> > > > > On Wed, Oct 06, 2004 at 10:26:13AM -0600, Andrew Patterson wrote:
> > > > > 
> > > > > > Note: here is the error you get when scsi_id is run without any
> > > > > > parameters:
> > > > > > 
> > > > > > # /sbin/scsi_id
> > > > > > -s must be specified
> > > > > 
> > > > > For the udev PROGRAM rules with no arguments, it is effectively invoked
> > > > > like this (well there are other environment values but scsi_id only cares
> > > > > about DEVPATH):
> > > > > 
> > > > > DEVPATH=/block/sda /sbin/scsi_id block
> > > > > 
> > > > 
> > > > This is what I thought was supposed to happen.  I printed out the
> > > > arguments and the environment when scsi_id was invoked through
> > > > udevstart.  No arguments were passed and UDEVPATH was always set
> > > > to /class/net/lo for every path in /sys.  Note that DEVNAME does seem to
> > > > be set correctly.
> > > 
> > > Yes, this is a bug. We need to export the DEVPATH for the callout if we
> > > run as udevstart. I will fix that now.
> > 
> > So did you confirm that the subsystem is indeed being passed as an
> > argument when running udevstart as well?  My testing shows no.  I think
> > you need both to make this work.
> 
> Yes, when udevstart was running we didn't set the environment and the
> subsystem argument for the callouts the dev.d/ scripts.
> 
> Here is a fix, that sets that with every udevstart iteration, corrects
> argv[0] to be the basename() only not the whole path  and adds a test
> for invoking callouts without arguments.

Applied, thanks.

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel