Re: [udev PATCH] pass SYSFS setting down for extras builds

[Patrick Mansfield <patmans@us.ibm.com>]

On Thu, Oct 14, 2004 at 01:51:11PM -0700, Greg KH wrote:
> On Thu, Oct 14, 2004 at 01:43:13PM -0700, Patrick Mansfield wrote:
> > Modify SYSFS to specify the full path, and pass it down for the extras
> > builds.
> 
> No, this reverts the change I made yesterday in order to get the build
> to look properly with the new "pretty" build system.
> 
> Now, if you want to fix up the ccdv program to properly pick out the
> file name so that I can apply this patch, I'd be glad to take that
> fix... :)

What did I revert?

It does not look pretty for extras builds with or without my patch; the
udev portion of the builds looks the same.

I just pulled and didn't see any updates.

Here's my build output (cut and pasted), it is the same with and without my
patch applied:

[elm3b79 udev-bk]$ make EXTRAS=extras/scsi_id -j9
Creating udev_version.h
Building ccdv
Compiling udev.c:                                                     [OK]
Compiling udev_lib.c:                                                 [OK]
Compiling udev_remove.c:                                              [OK]
Compiling udevdb.c:                                                   [OK]
Compiling udevstart.c:                                                [OK]
Compiling udev_config.c:                                              [OK]
Compiling dev_d.c:                                                    [OK]
Compiling udev_add.c:                                                 [OK]
  udev_add.c:108: warning: declaration of `major' shadows global declaration
  udev_add.c:108: warning: declaration of `minor' shadows global declaration
  udev_add.c: In function `make_node':
  udev_add.c:109: warning: declaration of `minor' shadows global declaration
  udev_add.c:109: warning: declaration of `major' shadows global declaration
Compiling namedev_parse.c:                                            [OK]
Compiling dlist.c:                                                    [OK]
Compiling sysfs_bus.c:                                                [OK]
Compiling sysfs_driver.c:                                             [OK]
Compiling sysfs_class.c:                                              [OK]
Compiling namedev.c:                                                  [OK]
Compiling spinlock.c:                                                 [OK]
Compiling sysfs_utils.c:                                              [OK]
Compiling udevsend.c:                                                 [OK]
Compiling sysfs_device.c:                                             [OK]
Compiling sysfs_dir.c:                                                [OK]
Compiling udevtest.c:                                                 [OK]
Compiling wait_for_sysfs.c:                                           [OK]
  wait_for_sysfs.c: In function `main':
  wait_for_sysfs.c:280: warning: `class_dev' might be used uninitialized in thi
  s function
Compiling udevinfo.c:                                                 [OK]
Compiling udevd.c:                                                    [OK]
Compiling tdb.c:                                                      [OK]
Linking udevd:                                                        [OK]
Linking udevsend:                                                     [OK]
Running strip:                                                        [OK]
Running strip:                                                        [OK]
Linking udev:                                                         [OK]
Linking wait_for_sysfs:                                               [OK]
Linking udevinfo:                                                     [OK]
Linking udevtest:                                                     [OK]
Running strip:                                                        [OK]
Running strip:                                                        [OK]
Running strip:                                                        [OK]
Running strip:                                                        [OK]
extras/scsi_id
make[1]: Entering directory `/home/patman/linux/src/udev-bk/extras/scsi_id'
gcc -pipe -DUSE_SPINLOCKS -DINTEL_SPINLOCKS -DLOG -Os -fomit-frame-pointer -D_GNU_SOURCE -Wall  -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -I/usr/lib/gcc-lib/i386-linux/2.95.4/include -I/home/patman/linux/src/udev-bk/libsysfs -Wall -fno-builtin   -c -o scsi_id.o scsi_id.c
gcc -pipe -DUSE_SPINLOCKS -DINTEL_SPINLOCKS -DLOG -Os -fomit-frame-pointer -D_GNU_SOURCE -Wall  -Wshadow -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -I/usr/lib/gcc-lib/i386-linux/2.95.4/include -I/home/patman/linux/src/udev-bk/libsysfs -Wall -fno-builtin   -c -o scsi_serial.o scsi_serial.c
gcc  -o scsi_id  scsi_id.o scsi_serial.o ../../libsysfs/sysfs_bus.o ../../libsysfs/sysfs_class.o ../../libsysfs/sysfs_device.o ../../libsysfs/sysfs_dir.o ../../libsysfs/sysfs_driver.o ../../libsysfs/sysfs_utils.o ../../libsysfs/dlist.o -lc
make[1]: Leaving directory `/home/patman/linux/src/udev-bk/extras/scsi_id'




-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel