From: Frank Mori Hess <fmhess@users.sourceforge.net>
To: linux-hotplug@vger.kernel.org
Subject: fxload fix
Date: Fri, 15 Oct 2004 02:01:34 +0000 [thread overview]
Message-ID: <200410142203.26658.fmhess@users.sourceforge.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 283 bytes --]
Hi,
I've got a one-line patch attached for fxload. Without it, it chokes on
Intel hex image files, unless you add a garbage character to the end of
every line. I suppose using DOS instead of UNIX end of line characters in
the firmware file would also avoid the bug.
--
Frank
[-- Attachment #2: ezusb_diff --]
[-- Type: text/x-diff, Size: 290 bytes --]
--- ezusb.c 2004-10-14 21:39:41.000000000 -0400
+++ ezusb-fixed.c 2004-10-14 21:40:27.000000000 -0400
@@ -361,7 +361,7 @@
return -3;
}
- if ((len * 2) + 11 >= strlen(buf)) {
+ if ((len * 2) + 11 > strlen(buf)) {
fprintf (stderr, "record too short?\n");
return -4;
}
[-- Attachment #3: Type: Text/Plain, Size: 542 bytes --]
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
I've got a one-line patch attached for fxload. Without it, it chokes on
Intel hex image files, unless you add a garbage character to the end of
every line. I suppose using DOS instead of UNIX end of line characters in
the firmware file would also avoid the bug.
- --
Frank
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFBby9+5vihyNWuA4URAlOJAKDpmCPfkYXNjF/1JRDyg0g7leJaDgCgxKSh
Ow5I6aPZvFCF+3yat1h7Rpk=
=t1G5
-----END PGP SIGNATURE-----
[-- Attachment #4: ezusb_diff --]
[-- Type: text/x-diff, Size: 290 bytes --]
--- ezusb.c 2004-10-14 21:39:41.000000000 -0400
+++ ezusb-fixed.c 2004-10-14 21:40:27.000000000 -0400
@@ -361,7 +361,7 @@
return -3;
}
- if ((len * 2) + 11 >= strlen(buf)) {
+ if ((len * 2) + 11 > strlen(buf)) {
fprintf (stderr, "record too short?\n");
return -4;
}
reply other threads:[~2004-10-15 2:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410142203.26658.fmhess@users.sourceforge.net \
--to=fmhess@users.sourceforge.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).