linux-hotplug.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [udev PATCH] pass SYSFS setting down for extras builds
Date: Fri, 15 Oct 2004 17:52:45 +0000	[thread overview]
Message-ID: <20041015175245.GA14568@kroah.com> (raw)
In-Reply-To: <20041014204313.GA12296@beaverton.ibm.com>

On Thu, Oct 14, 2004 at 02:20:13PM -0700, Patrick Mansfield wrote:
> On Thu, Oct 14, 2004 at 01:51:11PM -0700, Greg KH wrote:
> > On Thu, Oct 14, 2004 at 01:43:13PM -0700, Patrick Mansfield wrote:
> > > Modify SYSFS to specify the full path, and pass it down for the extras
> > > builds.
> > 
> > No, this reverts the change I made yesterday in order to get the build
> > to look properly with the new "pretty" build system.
> > 
> > Now, if you want to fix up the ccdv program to properly pick out the
> > file name so that I can apply this patch, I'd be glad to take that
> > fix... :)
> 
> What did I revert?

A change I made to the Makefile in order to get the extras/ stuff to
build again...

> It does not look pretty for extras builds with or without my patch; the
> udev portion of the builds looks the same.
> 
> I just pulled and didn't see any updates.
> 
> Here's my build output (cut and pasted), it is the same with and without my
> patch applied:

<snip>

Hm, I have no idea why this works for you, and not me.

But I've fixed up the ccdv.c program now, and applied your patch.

I also just commited a patch that made the scsi_id and volume_id
programs build in the same "pretty" manner as the main udev program.  It
should not break your ability to build scsi_id out side of the build
tree at all.

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

      parent reply	other threads:[~2004-10-15 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-14 20:43 [udev PATCH] pass SYSFS setting down for extras builds Patrick Mansfield
2004-10-14 20:51 ` Greg KH
2004-10-14 21:20 ` Patrick Mansfield
2004-10-15 17:52 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041015175245.GA14568@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).