Re: Problem parsing %s in udev rules

[Greg KH <greg@kroah.com>]

On Thu, Oct 14, 2004 at 02:05:49PM -0600, Andrew Patterson wrote:
> > > > > I also wonder if it might be a good idea to do some sort of
> > > > > transformation for characters in an attribute that are illegal in a file
> > > > > system, rather than just chopping everything off. e.g, spaces that are
> > > > > not leading or trailing would be changed to underscores.
> > > > 
> > > > ick, no.
> > > 
> > > Really?  Care to elaborate? 
> > > 
> > > Do you not like any transformation (besides the "let's chop off
> > > everything after anything illegal") or just the underscores for spaces
> > > one?  Perhaps a configuration value to make it optional? This sort of
> > > thing might relieve a lot of the script writing that must be done to
> > > handle cases that may be common.
> > 
> > Have you run into any cases where something like this is needed?  I
> > don't really want to do any transformation within udev itself if
> > possible, as it's a slippery slope down...  Helper programs can be used
> > if people run into anything really nasty, and the fact that this hasn't
> > come up yet, lends me to belive it really isn't a problem.  
> > 
> > Do you have any device that would need such transformation?
> 
> Need, no.  Want perhaps.  Example: using the following rule:
> 
> BUS="scsi", KERNEL="sd*", NAME="%k", SYMLINK="scsi_disks/%s{vendor}-%
> s{model}"
> 
> I have this stupid disk drive that has the following vendor and model
> entry:
> 
> Vendor: HP 36.4G Model: ST336753LC
> 
> So the resulting device file created by udev is
> /dev/scsi_disks/HP-ST336753LC
> 
> Intuitively, I would expect /dev/scsi_disks/HP 36.4G-ST336753LC.
> Given that spaces are bad, it would be be nice to see something like:
> 
> /dev/scsi_disks/HP_36.4G-ST336753LC.

Then I suggest you use a helper program to create such an insane name :)
Seriously, there are a load of better things to use to create a name,
than a vendor provided string.

> Is the %s stuff used a lot?

I think in this manner, no.

thanks,

greg k-h


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel