* volume_id fix
@ 2004-10-18 19:42 Kay Sievers
2004-10-18 19:55 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Kay Sievers @ 2004-10-18 19:42 UTC (permalink / raw)
To: linux-hotplug
[-- Attachment #1: Type: text/plain, Size: 60 bytes --]
I've been told that open() should not pass O_NONBLOCK.
Kay
[-- Attachment #2: udev-volume_id-01.patch --]
[-- Type: text/plain, Size: 384 bytes --]
===== extras/volume_id/volume_id.c 1.7 vs edited =====
--- 1.7/extras/volume_id/volume_id.c 2004-10-06 00:36:16 +02:00
+++ edited/extras/volume_id/volume_id.c 2004-10-18 21:16:20 +02:00
@@ -2128,7 +2128,7 @@
struct volume_id *id;
int fd;
- fd = open(path, O_RDONLY | O_NONBLOCK);
+ fd = open(path, O_RDONLY);
if (fd < 0) {
dbg("unable to open '%s'", path);
return NULL;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: volume_id fix
2004-10-18 19:42 volume_id fix Kay Sievers
@ 2004-10-18 19:55 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2004-10-18 19:55 UTC (permalink / raw)
To: linux-hotplug
On Mon, Oct 18, 2004 at 09:42:55PM +0200, Kay Sievers wrote:
> I've been told that open() should not pass O_NONBLOCK.
Applied, thanks.
greg k-h
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-10-18 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-18 19:42 volume_id fix Kay Sievers
2004-10-18 19:55 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).