[PATCH] fxload fix

[PATCH] fxload fix

[Frank Mori Hess]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

--Boundary-00=_b+ybBv0OXckQSSY
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

I've got a one-line patch attached for fxload.  Without it, it chokes on 
Intel hex image files, unless you add a garbage character to the end of 
every line.  I suppose using DOS instead of UNIX end of line characters in 
the firmware file would also avoid the bug.

[-- Attachment #2: Type: text/plain, Size: 293 bytes --]

Hi,

Is fxload unmaintained?  There haven't been any commits in 2 years, and I'm 
noticing a bug report from 3 months ago here

http://sourceforge.net/tracker/index.php?func=detail&aid=994005&group_id=17679&atid=117679

that fixes the same problem I reported last week (patch attached again).

[-- Attachment #3: ezusb_diff --]
[-- Type: text/x-diff, Size: 290 bytes --]

--- ezusb.c	2004-10-14 21:39:41.000000000 -0400
+++ ezusb-fixed.c	2004-10-14 21:40:27.000000000 -0400
@@ -361,7 +361,7 @@
 	    return -3;
 	}
 
-	if ((len * 2) + 11 >= strlen(buf)) {
+	if ((len * 2) + 11 > strlen(buf)) {
 	    fprintf (stderr, "record too short?\n");
 	    return -4;
 	}

Re: [PATCH] fxload fix

[David Brownell]

On Monday 18 October 2004 5:03 pm, Frank Mori Hess wrote:
> Hi,
> 
> Is fxload unmaintained?

I think all critical bugs that have landed in my mailbox have
gotten fixed within a month or so, but it's not exactly something
I've got much time for (and nobody else seems to commit to it).


> There haven't been any commits in 2 years, and I'm  
> noticing a bug report from 3 months ago here

That bug database would seem to be a bit like a bitbucket, eh?
Didn't even know it was in use.


> that fixes the same problem I reported last week (patch attached again).

Hmm, I saw you post of last week and it's in a stack of a few hundred
emails I was hoping to handle soon.  Higher priority than some, since
it seemed to actually fix a minor bug (easy workaround) and the fix
was already done!

Hold your horses ... ;)

- Dave






-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel