[PATCH] eth1394: dev file [Report about error: unknown bus]

[PATCH] eth1394: dev file [Report about error: unknown bus]

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

Kay Sievers wrote:
> On Wed, Oct 20, 2004 at 01:44:58PM -0400, Paul Blazejowski wrote:
> 
>>On Wed, 2004-10-20 at 15:17 +0200, Kay Sievers wrote:
>>
>>
>>>>'/class/net/eth1' properly (no device symlink) or the sysfs-support of
>>>>your device's driver needs to be fixed
>>>
>>>What driver creates the eth1 device? It needs to crete the "device" symlink
>>>and the maintainer should know.
>>
>>eth1      Link encap:UNSPEC  HWaddr
>>8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00
>>
>>is created by the eth1394 driver.
> 
> 
> [CC: to the 1394 devel-list]
> 
> The eth1394.c driver needs to create the symlinks in its sysfs
> representation to get support for modern userspace integration.
> Most networkd drivers use:
> 
>   SET_NETDEV_DEV(dev, &pdev->dev);
> 
> to do that.

Paul,
Can you test this patch, please?

Thanks,
-- 
~Randy

[-- Attachment #2: eth1394_sysfs.patch --]
[-- Type: text/x-patch, Size: 443 bytes --]

linux-269-bk4
description

diffstat:=

diff -Naurp ./drivers/ieee1394/eth1394.c~eth1394_sysfs ./drivers/ieee1394/eth1394.c
--- ./drivers/ieee1394/eth1394.c~eth1394_sysfs	2004-10-20 16:01:51.765776760 -0700
+++ ./drivers/ieee1394/eth1394.c	2004-10-20 16:27:33.126454320 -0700
@@ -600,6 +600,7 @@ static void ether1394_add_host (struct h
         }
 
 	SET_MODULE_OWNER(dev);
+	SET_NETDEV_DEV(dev, &host->device);
 
 	priv = netdev_priv(dev);
 

Re: [PATCH] eth1394: dev file [Report about error: unknown bus]

[Paul Blazejowski]

[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]

On Wed, 2004-10-20 at 16:26 -0700, Randy.Dunlap wrote:
> Kay Sievers wrote:
> > On Wed, Oct 20, 2004 at 01:44:58PM -0400, Paul Blazejowski wrote:
> > 
> >>On Wed, 2004-10-20 at 15:17 +0200, Kay Sievers wrote:
> >>
> >>
> >>>>'/class/net/eth1' properly (no device symlink) or the sysfs-support of
> >>>>your device's driver needs to be fixed
> >>>
> >>>What driver creates the eth1 device? It needs to crete the "device" symlink
> >>>and the maintainer should know.
> >>
> >>eth1      Link encap:UNSPEC  HWaddr
> >>8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00
> >>
> >>is created by the eth1394 driver.
> > 
> > 
> > [CC: to the 1394 devel-list]
> > 
> > The eth1394.c driver needs to create the symlinks in its sysfs
> > representation to get support for modern userspace integration.
> > Most networkd drivers use:
> > 
> >   SET_NETDEV_DEV(dev, &pdev->dev);
> > 
> > to do that.
> 
> Paul,
> Can you test this patch, please?
> 
> Thanks,

Randy applied the patch to kernel 2.6.9 and now eth1394 creates symlink
under /sys/class/net/eth2

lrwxrwxrwx  1 root root    0 2004-10-20 23:58 device
-> ../../../devices/pci0000:00/0000:00:0d.0/fw-host0/

Thank you,

Paul
-- 
FreeBSD -- The Power to Serve!

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] eth1394: dev file [Report about error: unknown bus]

[Randy.Dunlap]

Paul Blazejowski wrote:
> On Wed, 2004-10-20 at 16:26 -0700, Randy.Dunlap wrote:
> 
>>Kay Sievers wrote:
>>
>>>On Wed, Oct 20, 2004 at 01:44:58PM -0400, Paul Blazejowski wrote:
>>>
>>>
>>>>On Wed, 2004-10-20 at 15:17 +0200, Kay Sievers wrote:
>>>>
>>>>
>>>>
>>>>>>'/class/net/eth1' properly (no device symlink) or the sysfs-support of
>>>>>>your device's driver needs to be fixed
>>>>>
>>>>>What driver creates the eth1 device? It needs to crete the "device" symlink
>>>>>and the maintainer should know.
>>>>
>>>>eth1      Link encap:UNSPEC  HWaddr
>>>>8A-1C-C7-FF-FF-00-20-ED-00-00-00-00-00-00-00-00
>>>>
>>>>is created by the eth1394 driver.
>>>
>>>
>>>[CC: to the 1394 devel-list]
>>>
>>>The eth1394.c driver needs to create the symlinks in its sysfs
>>>representation to get support for modern userspace integration.
>>>Most networkd drivers use:
>>>
>>>  SET_NETDEV_DEV(dev, &pdev->dev);
>>>
>>>to do that.
>>
>>Paul,
>>Can you test this patch, please?
>>
>>Thanks,
> 
> 
> Randy applied the patch to kernel 2.6.9 and now eth1394 creates symlink
> under /sys/class/net/eth2
> 
> lrwxrwxrwx  1 root root    0 2004-10-20 23:58 device
> -> ../../../devices/pci0000:00/0000:00:0d.0/fw-host0/
> 
> Thank you,
> 
> Paul

So is this correct?  Does it do the right thing?

-- 
~Randy


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

Re: [PATCH] eth1394: dev file [Report about error: unknown bus]

[Kay Sievers]

On Thu, Oct 21, 2004 at 12:22:46AM -0400, Paul Blazejowski wrote:
> On Wed, 2004-10-20 at 21:10 -0700, Randy.Dunlap wrote:
> 
> > > Randy applied the patch to kernel 2.6.9 and now eth1394 creates symlink
> > > under /sys/class/net/eth2
> > > 
> > > lrwxrwxrwx  1 root root    0 2004-10-20 23:58 device
> > > -> ../../../devices/pci0000:00/0000:00:0d.0/fw-host0/
> > > 
> > > Thank you,
> > > 
> > > Paul
> > 
> > So is this correct?  Does it do the right thing?

Yes, I think so.
Randy, thanks a lot for the fast fix.

> udev still complains about bus specific file
> unavailable 

I hopefully fixed this one now.
Paul, I will send a new patch in reply to your other mail.

Thanks,
Kay


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel