Re: udev-039-6 on Fedora Core 3

[Kay Sievers <kay.sievers@vrfy.org>]

On Mon, Oct 25, 2004 at 02:09:36PM +0200, Harald Hoyer wrote:


> I added several patches to udev-039 which will be on FC3.
> I only describe the most patches here. The patches itsself are in the 
> src.rpm and can be posted on request.

Cool, somebody sharing...
I've looked at all patches in the SRPM. Some comments on it:

> Patch1: udev-039-static.patch
> makes inline getpwnam and getgrnam functions, which are used for the static 
> version of udev, which is used in initramfs

Why don't you compile it with klibc? Everything should work. The
klibc-version is also be able to parse /etc/passwd to keep the same
permissions file in initrd.

> Patch2: udev-025-volsbin.patch
> moves volume_id from /usr/sbin to /sbin (such tools should not live in 
> /usr, because /usr could be nfs-mounted

Right, should go in our tree.

> Patch3: udev-039-wait-error-log.patch
> wait_for_sysfs patch

Already in current version!

> Patch4: udev-039-logging.patch
> logging patch

Already in current version!

> Patch5: udev-039-wait-ppp-class.patch
> wait_for_sysfs patch

Already in current version!

> Patch6: udev-039-wait-dm-block.patch
> wait_for_sysfs patch

Already in current version!

> Patch7: udev-039-static2.patch
> include wait_for_sysfs in udev for the static udev version used in initramfs

Huh, #include of an .c file :)
The current version has a udev_sysfs.c file for that. I'm on converting
everything to a be more like a toolbox. Something like this should only
need a few lines of code now and you only need to open the device once.

> Patch8: udev-039-netif.patch
> only call dev_d_send for network interfaces, if the name was changed

Already in current version!

> Patch9: udev-039-dummy.patch
> wait_for_sysfs patch

Already in current version!

> Patch10: udev-039-volume_id-nonblock.patch
> do not open(2) with O_NONBLOCK

Already in current version!

> Patch11: udev-039-norm.patch
> add NOREMOVE keyword to the rules. this was necessary because removable ide 
> devices were added/removed for every open(2)/close(2)
> added to the rules:
> KERNEL="hd[a-z]*", NOREMOVE="1"
> 
> this could eventually be refined by checking the "removable" 
> sysfs-attribute, but not for partitions..

I see the need for that, yes. But I would like to have a match of the
ACTION string instead. This would make it more flexible. Something like:

  KERNEL="abc", ACTION="add", NAME="xyz"

> Patch22: udev-032-symlink.patch
> replace format directives in every symlink part

Not needed, I think. Should work out of the box as the format replacement
will not stop at the spaces in the symlink string. If you have problems
with that, then we have a bug and please tell us.

> Patch24: udev-038-volmak.patch
> Makefile patch for volume_id

Should go in our tree. What was the problem here, On my box, this is working.


Harald,
I will take care, that:
  udev-038-volmak.patch,
  udev-025-volsbin.patch
are getting upstream.

Please give me some feedback on:
  udev-039-norm.patch,
  udev-032-symlink.patch,
  udev-039-static.patch

Thanks,
Kay


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel