From: Andrew Morton <akpm@osdl.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: chicken/egg between pipefs and initramfs/hotplug
Date: Thu, 28 Oct 2004 07:42:25 +0000 [thread overview]
Message-ID: <20041028004225.617ee76c.akpm@osdl.org> (raw)
In-Reply-To: <1098729008.19348.80.camel@tubarao>
Bob Barry <bobb@absamail.co.za> wrote:
>
> > you wrote:
> > > It appears that linux/init/main.c:init() has a chicken/egg problem...
> > Andrew Morton replied:
> > That's a bit sad. Does this fix it?
> >
> > --- 25/fs/pipe.c~a Tue Oct 26 16:28:44 2004
> > +++ 25-akpm/fs/pipe.c Tue Oct 26 16:28:52 2004
> > @@ -718,5 +718,5 @@ static void __exit exit_pipe_fs(void)
> > mntput(pipe_mnt);
> > }
> >
> > -module_init(init_pipe_fs)
> > +fs_initcall(init_pipe_fs)
> > module_exit(exit_pipe_fs)
> > _
> >
>
> Did that patch work for you?
No, the macros we use in there are borked. Try this:
--- 25/fs/pipe.c~convert-pipefs-to-fs_initcall 2004-10-26 20:06:05.293263776 -0700
+++ 25-akpm/fs/pipe.c 2004-10-26 20:13:52.998161824 -0700
@@ -718,5 +718,5 @@ static void __exit exit_pipe_fs(void)
mntput(pipe_mnt);
}
-module_init(init_pipe_fs)
-module_exit(exit_pipe_fs)
+fs_initcall(init_pipe_fs);
+module_exit(exit_pipe_fs);
_
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id\x12065&opÌk
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2004-10-28 7:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-25 18:30 chicken/egg between pipefs and initramfs/hotplug Thayne Harbaugh
2004-10-26 23:29 ` Andrew Morton
2004-10-28 14:23 ` Thayne Harbaugh
2004-10-28 7:23 ` Bob Barry
2004-10-28 7:42 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041028004225.617ee76c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).