From: sjoerd@spring.luon.net (Sjoerd Simons)
To: linux-hotplug@vger.kernel.org
Subject: [udev] DEVNAME on device removal
Date: Mon, 22 Nov 2004 19:38:36 +0000 [thread overview]
Message-ID: <20041122193836.GA17405@spring.luon.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
Hi,
I just noticed that the DEVNAME enviroment variable isn't being set anymore
in udev 0.046 on device removal, while it was being set in 0.042. We're using
the property tto do umount -l <devices> when a block device is removed. Afaik
there is no other way to associate a device with it's DEVNAME on removal ?
Also are there cases where doing umount -l on the removed devices is wrong?
I guess the device is gone, so there is no sense in keeping it mounted (it's
not like the filesystem is gonna come back in a sane state again)..
Attached (trivial) patch brings back the DEVNAME variable on device removal.
Sjoerd
--
The optimist thinks that this is the best of all possible worlds,
and the pessimist knows it.
-- J. Robert Oppenheimer, "Bulletin of Atomic Scientists"
[-- Attachment #2: devname.patch --]
[-- Type: text/plain, Size: 449 bytes --]
diff -Naur udev-046.orig/udev.c udev-046/udev.c
--- udev-046.orig/udev.c 2004-11-18 20:39:15.000000000 +0100
+++ udev-046/udev.c 2004-11-22 18:43:58.000000000 +0100
@@ -179,6 +179,10 @@
/* get node from db, delete it*/
retval = udev_remove_device(&udev);
+ /* Set the DEVNAME if known */
+ if (udev.devname[0] != '\0') {
+ setenv("DEVNAME", udev.devname, 1);
+ }
/* run scripts */
dev_d_execute(&udev, DEVD_DIR, DEVD_SUFFIX);
}
next reply other threads:[~2004-11-22 19:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-22 19:38 Sjoerd Simons [this message]
2004-11-22 19:55 ` [udev] DEVNAME on device removal Kay Sievers
2004-11-23 7:50 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041122193836.GA17405@spring.luon.net \
--to=sjoerd@spring.luon.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).