From: Paul Jackson <pj@sgi.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH, UDEV] change no_trailing_slash() to remove all trailing
Date: Sat, 05 Feb 2005 22:04:32 +0000 [thread overview]
Message-ID: <20050205140432.19acf0da.pj@sgi.com> (raw)
In-Reply-To: <200502051818.54277.mbuesch@freenet.de>
Michael wrote:
> while (len > 0 && path[len-1] = '/')
I think you'd better make that:
while (len > 1 && path[len-1] = '/')
or else you can eat your last slash.
The call no_trailing_slash("/") should produce "/", not "".
Not that anyone is likely to call no_trailing_slash("////")
very often ;).
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373, 1.925.600.0401
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
next prev parent reply other threads:[~2005-02-05 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-05 17:18 [PATCH, UDEV] change no_trailing_slash() to remove all trailing slashes Michael Buesch
2005-02-05 18:15 ` [PATCH, UDEV] change no_trailing_slash() to remove all Kay Sievers
2005-02-05 22:04 ` Paul Jackson [this message]
2005-02-05 22:36 ` [PATCH, UDEV] change no_trailing_slash() to remove all trailing slashes Michael Buesch
2005-02-06 1:11 ` [PATCH, UDEV] change no_trailing_slash() to remove all trailing Paul Jackson
2005-02-06 9:54 ` [PATCH, UDEV] change no_trailing_slash() to remove all trailing slashes Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050205140432.19acf0da.pj@sgi.com \
--to=pj@sgi.com \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).