Re: [PATCH, UDEV] change no_trailing_slash() to remove all trailing slashes

[Michael Buesch <mbuesch@freenet.de>]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

Quoting Paul Jackson <pj@sgi.com>:
> Michael wrote:
> > 	while (len > 0 && path[len-1] == '/')
> 
> I think you'd better make that:
> 
> 	while (len > 1 && path[len-1] == '/')
> 
> or else you can eat your last slash.
> 
> The call no_trailing_slash("/") should produce "/", not "".

Well, I would call that expected behaviour.
Consider the following:
char buf[SIZE];
strcpy(buf, "///");
no_trailing_slash(buf);
strcat(buf, "/foo/bar");

I would expect that to expand to "/foo/bar" and _not_
to "//foo/bar" as you suggest.

> Not that anyone is likely to call no_trailing_slash("////")
> very often ;).
> 

-- 
Regards Michael Buesch  [ http://www.tuxsoft.de.vu ]



[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]