Re: [PATCH, UDEV] change no_trailing_slash() to remove all trailing slashes

[Michael Buesch <mbuesch@freenet.de>]

[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]

Quoting Paul Jackson <pj@sgi.com>:
> What if someone does:
> 
>     strcpy(buf, "/");
>     no_trailing_slash(buf);
>     strcat(buf, "foo");
> 
> Would you expect "foo", or "/foo" ?

I would expect "foo".
It's the function semantics:
no_trailing_slash means (at least for me) clearly,
that there will be "no trailing slash" under any circumstances in
the string.
It should be the caller's job to ensure, that we have a
valid path after cutting of all trailing slashes.

	strcpy(buf, "/");
	no_trailing_slash(buf);
	if (buf[0] == '\0')
		strcat(buf, "/");
	strcat(buf, "foo");

But having saied this all, I can't find where this
actually happens in the udev code. I did a very quick
search even before I submitted the code, but I could only
find places like this, which will always result
in a valid path:

	no_trailing_slash(buf);
	strcat(buf, "/foo");

> Actually, I did not expect this to be called in the middle
> of a construction, after only explicit constant strings
> had been added.
> 
> I would have expected it to be called after the final
> construction, following the concatenation of a variable
> string.
> 
> And I would have expected it to scrupulously avoid changing
> the meaning of the path - just cosmetic trimming.
> 
> But apparently my expectations are confused.  Feel free to
> dismiss my comments.
> 

-- 
Regards Michael Buesch  [ http://www.tuxsoft.de.vu ]



[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]